public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oliver@neukum.org>
To: "Keith Chew" <keith.chew@gmail.com>
Cc: linux-usb-devel@lists.sourceforge.net,
	"Chuck Ebbert" <cebbert@redhat.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [linux-usb-devel] usb_fill_bulk_urb() broken for USB1.1?
Date: Wed, 27 Jun 2007 09:35:14 +0200	[thread overview]
Message-ID: <200706270935.14657.oliver@neukum.org> (raw)
In-Reply-To: <20f65d530706270030y5650e302yc5136adc0ac8dd46@mail.gmail.com>

Am Mittwoch, 27. Juni 2007 schrieb Keith Chew:
> Hi Oliver
> 
> >
> > What do you use as arguments for usb_fill_bulk_urb() ? One of the sanity tests
> > in usb_submit_urb() is triggered.
> >
> 
> Usage:
> 
> 	usb_fill_bulk_urb(macp->intr_urb, macp->usb,
> 		usb_rcvbulkpipe(macp->usb, EP_INT_IN),
> 		macp->IntEPBuffer, MAX_EPINT_BUFFER,
> 		zd1211_intr_cb, macp);

See Pete's post.

You are initialising an interrupt urb with an initializer for
a bulk urb. The behavior is undefined. In older kernels
by random chance a sensible interval was set.

You need to use the correct initializer and the correct interval,
which usually can be read from the device's descriptors.

	Regards
		Oliver


  reply	other threads:[~2007-06-27  7:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-26 14:20 usb_fill_bulk_urb() broken for USB1.1? Keith Chew
2007-06-26 17:52 ` Chuck Ebbert
2007-06-26 19:30   ` Pete Zaitcev
2007-06-27  6:27   ` [linux-usb-devel] " Oliver Neukum
2007-06-27  7:30     ` Keith Chew
2007-06-27  7:35       ` Oliver Neukum [this message]
2007-06-27 22:54         ` Keith Chew
2007-06-27  7:11   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706270935.14657.oliver@neukum.org \
    --to=oliver@neukum.org \
    --cc=cebbert@redhat.com \
    --cc=keith.chew@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox