Re: [PATCH] LinuxPPS (with new syscalls API) - new version

Rodolfo Giometti
2007-07-01T19:23:41Z

On Sun, Jul 01, 2007 at 05:13:25PM +1000, Stephen Rothwell wrote:
> On Sat, 30 Jun 2007 19:13:40 +0200 Rodolfo Giometti <giometti@enneenne.com> wrote:
> >
> > Maybe I can define a special struct for exchanging time data as:
> >
> > struct pps_timedata_s {
> > long sec;
> > long nsec;
> > }
> >
> > and managing time data conversions at userland...
> >
> > What do you think about that? :)
>
> "long" is one of the datatypes that changes size between 32 bit and 64
> bit, so not such a good choice. You could use __u32 or __64 (or
> whatever), that makes it very clear that these are fixed size data types.

struct pps_timedata_s {
__32 sec;
__32 nsec;
}

Ok? I think 32 bits are enought for keeping seconds... :)

If you have no more advices I think I can start changing this part in
order to avoid using struct timespec.

Ciao,

Rodolfo