Re: [PATCH] LinuxPPS (with new syscalls API) - new version

Christoph Hellwig
2007-06-30T08:38:37Z

On Thu, Jun 28, 2007 at 06:14:50PM +0200, Rodolfo Giometti wrote:
> Hello,
>
> here my new LinuxPPS patch.
>
> What to do now for kernel inclusion? Should I provide several patches?
> If so how should I divide them?
>
> Thanks a lot,

Sorry for coming in that late, but using syscalls for something as
periphal sounds like a very bad idea to me, and the syscalls aren't
defined nicely either (e.g. you have an ioctl lookalike). I'd say
back to the drawingboard.

And yes, even ioctls are nicer than badly designed syscalls :)

Also code seems to be odd at least in a few places, e.g. all the access_oks
and double checks of the ioctl-lookalike commands should go.