From: Matthew Wilcox <matthew@wil.cx>
To: Matt Domsch <Matt_Domsch@dell.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
lkml <linux-kernel@vger.kernel.org>,
gregkh@suse.de, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: pci.h stubs (was: EDD build error)
Date: Wed, 27 Jun 2007 05:30:48 -0600 [thread overview]
Message-ID: <20070627113048.GU22063@parisc-linux.org> (raw)
In-Reply-To: <20070627024505.GA30197@humbolt.us.dell.com>
On Tue, Jun 26, 2007 at 09:45:05PM -0500, Matt Domsch wrote:
> On Tue, Jun 26, 2007 at 01:26:22PM -0700, Randy Dunlap wrote:
> > ERROR: "pci_get_bus_and_slot" [drivers/firmware/edd.ko] undefined!
>
> It should be stubbed, in include/linux/pci.h where all the other PCI
> functions are stubbed for the !CONFIG_PCI case.
pci_get_bus_and_slot() shouldn't be used because it fails to work on
systems with multiple domains. pci_get_slot() avoids this problem (and
is much faster too).
next prev parent reply other threads:[~2007-06-27 11:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 20:26 EDD build error Randy Dunlap
2007-06-26 22:16 ` Torsten Duwe
2007-06-26 22:33 ` Randy Dunlap
2007-06-26 22:44 ` Torsten Duwe
2007-06-26 23:14 ` Randy Dunlap
[not found] ` <20070627024505.GA30197@humbolt.us.dell.com>
2007-06-27 11:30 ` Matthew Wilcox [this message]
2007-06-27 13:55 ` pci.h stubs (was: EDD build error) Alan Cox
2007-06-27 14:03 ` Matthew Wilcox
2007-06-27 14:32 ` Alan Cox
2007-06-27 14:32 ` Matthew Wilcox
2007-06-27 15:07 ` Alan Cox
2007-06-27 16:41 ` pci.h stubs H. Peter Anvin
2007-06-27 16:54 ` Matthew Wilcox
2007-06-27 17:25 ` Alan Cox
2007-06-27 18:34 ` H. Peter Anvin
2007-06-28 23:04 ` [PATCH] PCI: limit pci_get_bus_and_slot to domain 0 Randy Dunlap
2007-06-28 23:48 ` H. Peter Anvin
2007-06-28 23:25 ` [PATCH] pci.h stubs (for EDD build error) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070627113048.GU22063@parisc-linux.org \
--to=matthew@wil.cx \
--cc=Matt_Domsch@dell.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox