From: Andrew Morton <akpm@linux-foundation.org>
To: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: linux-kernel@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] balance parenthesis in serial core
Date: Wed, 27 Jun 2007 13:37:17 -0700 [thread overview]
Message-ID: <20070627133717.d19d82c9.akpm@linux-foundation.org> (raw)
In-Reply-To: <200706272222.01300.m.kozlowski@tuxland.pl>
On Wed, 27 Jun 2007 22:22:00 +0200
Mariusz Kozlowski <m.kozlowski@tuxland.pl> wrote:
> Hello,
>
> This patch balances the parenthesis imbalance in serial core.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> drivers/serial/serial_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.22-rc6-bo-a/drivers/serial/serial_core.c 2007-06-27 22:05:41.000000000 +0200
> +++ linux-2.6.22-rc6-bo-b/drivers/serial/serial_core.c 2007-06-27 22:08:56.000000000 +0200
> @@ -1158,9 +1158,9 @@ static void uart_set_termios(struct tty_
> * appropriately by set_termios() in tty_ioctl.c
> */
> #ifdef CIBAUD
> -#define RELEVANT_CFLAG(cflag) ((cflag) & ~(CIBAUD|CBAUD)
> +#define RELEVANT_CFLAG(cflag) ((cflag) & ~(CIBAUD|CBAUD))
> #else
> -#define RELEVANT_CFLAG(cflag) ((cflag) & ~(CIBAUD|CBAUD)
> +#define RELEVANT_CFLAG(cflag) ((cflag) & ~(CIBAUD|CBAUD))
> #endif
> #define RELEVANT_IFLAG(iflag) ((iflag) & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK))
> if ((cflag ^ old_termios->c_cflag) == 0 &&
Thanks. so... why shouldn't we just remove the buggy&&unused RELEVANT_CFLAG
defines??
next prev parent reply other threads:[~2007-06-27 20:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-27 10:30 mm snapshot broken-out-2007-06-27-03-28.tar.gz uploaded akpm
2007-06-27 12:25 ` [PATCH] linux/cache.h export - workaround for headers_check error (Re: mm snapshot broken-out-2007-06-27-03-28.tar.gz uploaded) Michal Piotrowski
2007-06-27 20:22 ` [PATCH] balance parenthesis in serial core Mariusz Kozlowski
2007-06-27 20:37 ` Andrew Morton [this message]
2007-06-27 20:42 ` David Woodhouse
2007-06-27 20:49 ` Andrew Morton
2007-06-27 22:06 ` Alan Cox
2007-06-27 21:50 ` [PATCH] mtd: add module license to mtdbdi Mariusz Kozlowski
2007-06-28 7:21 ` David Howells
2007-06-27 22:57 ` mm snapshot broken-out-2007-06-27-03-28.tar.gz uploaded Mariusz Kozlowski
2007-06-27 23:09 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070627133717.d19d82c9.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox