public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Matt Mackall <mpm@selenic.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC #2] hwrng: Add type categories
Date: Wed, 27 Jun 2007 15:05:33 +0200	[thread overview]
Message-ID: <200706271505.33970.mb@bu3sch.de> (raw)
In-Reply-To: <20070627024856.GB5491@khazad-dum.debian.net>

On Wednesday 27 June 2007 04:48:56 Henrique de Moraes Holschuh wrote:
> (a) is just broken, unless one is to take it as "never use it".  And I am
> really not sure about (b).  It *is* better than just using whatever crap we
> found first (or last), but it is the wrong solution for a problem that we
> really should not have in the first place if someone had thought a bit
> before adding a misc device for something that has no reason to be unique in
> a system.

Well, we have that userspace ABI of one hwrng char device. I did not
invent that. It's kind of broken, yes.
And changing it in a compatible way is probably difficult.

> Instead of papering over the problem with borked solutions, maybe we should
> just export ALL HRNGs to userspace.  While at it, please add whatever is

And then we would _still_ export some kind of hint for rngd that
the CPU rng device should be preferred over the bcm43xx device.
rngd needs some basic hint about the devices.
How would you implement that? (We're back to my TYPE_XXX definitions ;) )

> needed so that userspace can talk to the kernel driver to get vital
> information about the HRNG device the driver might have (the current
> interface is a bad simplistic hack).

What is "vital information"? My TYPE_XXX categories? ;)

> Let userspace get the data from whichever HRNG it wants, process it in any

It _can_. We can switch the RNG in sysfs. So userspace _can_ get data
from whichever HWRNG it wants.

> way it wants and pipe it back through /dev/random IOCTLs.  And let it do it
> for as many HRNGs it wants at the same time.

That's an improvement, yes.

> And if you must have /dev/hw_random point somewhere, let udev scripts or
> something else like that take care of it.

Could do that, yes.


-- 
Greetings Michael.

  reply	other threads:[~2007-06-27 13:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-26 18:21 [PATCH RFC #2] hwrng: Add type categories Michael Buesch
2007-06-26 22:45 ` Matt Mackall
2007-06-27  2:40   ` Matt Mackall
2007-06-27  2:48   ` Henrique de Moraes Holschuh
2007-06-27 13:05     ` Michael Buesch [this message]
2007-06-27 13:10       ` Michael Buesch
2007-06-27 17:03       ` Henrique de Moraes Holschuh
2007-06-27 17:54         ` Michael Buesch
2007-06-28  8:07           ` Henrique de Moraes Holschuh
2007-07-08 12:53     ` Pavel Machek
2007-06-27 12:57   ` Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706271505.33970.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=akpm@linux-foundation.org \
    --cc=hmh@hmh.eng.br \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox