public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Christoph Hellwig <hch@infradead.org>,
	john stultz <johnstul@us.ibm.com>,
	Oleg Nesterov <oleg@tv-sign.ru>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Dipankar Sarma <dipankar@in.ibm.com>,
	"David S. Miller" <davem@davemloft.net>,
	kuznet@ms2.inr.ac.ru, Jonathan Corbet <corbet@lwn.net>,
	Arjan van de Ven <arjan@infradead.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: [RFC PATCH 5/8] Convert net wireless tasklet to workqueue
Date: Wed, 27 Jun 2007 15:36:38 -0400	[thread overview]
Message-ID: <20070627194327.938450052@goodmis.org> (raw)
In-Reply-To: 20070627193633.025544061@goodmis.org

[-- Attachment #1: convert-net-wireless-tasklet-workqueue.patch --]
[-- Type: text/plain, Size: 1332 bytes --]

Since we want to remove DECLARE_TASKLET API, there wasn't a simple way
to do that elegantly with net/core/wireless.c, so this patch just
replaces that tasklet with a work queue directly.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>


Index: linux-2.6-test/net/core/wireless.c
===================================================================
--- linux-2.6-test.orig/net/core/wireless.c
+++ linux-2.6-test/net/core/wireless.c
@@ -1916,7 +1916,7 @@ static int __init wireless_nlevent_init(
 
 subsys_initcall(wireless_nlevent_init);
 
-static void wireless_nlevent_process(unsigned long data)
+static void wireless_nlevent_process(struct work_struct *work)
 {
 	struct sk_buff *skb;
 
@@ -1924,7 +1924,7 @@ static void wireless_nlevent_process(uns
 		rtnl_notify(skb, 0, RTNLGRP_LINK, NULL, GFP_ATOMIC);
 }
 
-static DECLARE_TASKLET(wireless_nlevent_tasklet, wireless_nlevent_process, 0);
+static DECLARE_WORK(wireless_nlevent_wq, wireless_nlevent_process);
 
 /* ---------------------------------------------------------------- */
 /*
@@ -1989,7 +1989,7 @@ static inline void rtmsg_iwinfo(struct n
 	}
 	NETLINK_CB(skb).dst_group = RTNLGRP_LINK;
 	skb_queue_tail(&wireless_nlevent_queue, skb);
-	tasklet_schedule(&wireless_nlevent_tasklet);
+	schedule_work(&wireless_nlevent_wq);
 }
 
 #endif	/* WE_EVENT_RTNETLINK */

-- 

  parent reply	other threads:[~2007-06-27 19:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-27 19:36 [RFC PATCH 0/8] Convert all tasklets to workqueues V3 Steven Rostedt
2007-06-27 19:36 ` [RFC PATCH 1/8] Convert the RCU tasklet into a softirq Steven Rostedt
2007-07-16 20:12   ` Paul E. McKenney
2007-07-16 20:23     ` Linus Torvalds
2007-07-16 20:44       ` Steven Rostedt
2007-07-16 20:53         ` Ingo Molnar
2007-07-17  2:11           ` Paul E. McKenney
2007-07-16 20:48       ` Ingo Molnar
2007-06-27 19:36 ` [RFC PATCH 2/8] Split out tasklets from softirq.c Steven Rostedt
2007-06-27 19:36 ` [RFC PATCH 3/8] Add a tasklet is-scheduled API Steven Rostedt
2007-06-27 19:36 ` [RFC PATCH 4/8] Make DRM use the tasklet is-sched API Steven Rostedt
2007-06-27 19:36 ` Steven Rostedt [this message]
2007-06-27 19:36 ` [RFC PATCH 6/8] Remove DECLARE_TASKLET_DISABLE API Steven Rostedt
2007-06-27 19:36 ` [RFC PATCH 7/8] remove DECLARE_TASKLET API Steven Rostedt
2007-06-27 19:36 ` [RFC PATCH 8/8] Convert tasklets to work queues Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070627194327.938450052@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dipankar@in.ibm.com \
    --cc=hch@infradead.org \
    --cc=johnstul@us.ibm.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox