From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1762540AbXF0Tzo@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1762540AbXF0Tzo (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Jun 2007 15:55:44 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753818AbXF0TzQ
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 27 Jun 2007 15:55:16 -0400
Received: from mu-out-0910.google.com ([209.85.134.191]:63613 "EHLO
	mu-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753968AbXF0TzN (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Jun 2007 15:55:13 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-disposition:message-id:content-type:content-transfer-encoding;
        b=kKsdXTw58v5c8Dwsk+7M7QsMa0XfSg3zie7EAz0YPgyG4VzNneSFr2E13szOhyA4a4JkFrE/CWjMDCmaKHeJy9QjArHsUJre+tTA2E8TB4FtxZ856r6gN+F+p6zhId0nFalPBtkCfd9MzCvGPd/72fwKnz6xqeqr3hpP8XvyW7Y=
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH 4/5] sis5513: backport short cables support from pata_sis.c
Date: Wed, 27 Jun 2007 21:15:31 +0200
User-Agent: KMail/1.9.6
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <200706101558.33636.bzolnier@gmail.com> <46816011.70000@ru.mvista.com>
In-Reply-To: <46816011.70000@ru.mvista.com>
MIME-Version: 1.0
Content-Disposition: inline
Message-Id: <200706272115.31807.bzolnier@gmail.com>
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 26 June 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
> 
> > Backport short cables support from pata_sis.c.
> 
> > This patch should allow UDMA > 2 modes on ASUS A6K.
> 
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> 
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> 
> > Index: b/drivers/ide/pci/sis5513.c
> > ===================================================================
> > --- a/drivers/ide/pci/sis5513.c
> > +++ b/drivers/ide/pci/sis5513.c
> [...]
> > @@ -796,10 +796,33 @@ static unsigned int __devinit init_chips
> >  	return 0;
> >  }
> >  
> > +struct sis_laptop {
> > +	u16 device;
> > +	u16 subvendor;
> > +	u16 subdevice;
> > +};
> > +
> > +static const struct sis_laptop sis_laptop[] = {
> > +	/* devid, subvendor, subdev */
> > +	{ 0x5513, 0x1043, 0x1107 },	/* ASUS A6K */
> > +	/* end marker */
> > +	{ 0, }
> > +};
> > +
> >  static u8 __devinit ata66_sis5513(ide_hwif_t *hwif)
> >  {
> > +	struct pci_dev *pdev = hwif->pci_dev;
> > +	const struct sis_laptop *lap = &sis_laptop[0];
> >  	u8 ata66 = 0;
> >  
> > +	while (lap->device) {
> > +		if (lap->device == pdev->device &&
> > +		    lap->subvendor == pdev->subsystem_vendor &&
> > +		    lap->subdevice == pdev->subsystem_device)
> > +			return ATA_CBL_PATA40_SHORT;
> > +		lap++;
> > +	}
> > +
> 
>    The code even starts looking generic enough to be put into helper...

Hmm, agreed, now if somebody could send me a patch...

Thanks,
Bart