From: Alexey Dobriyan <adobriyan@sw.ru>
To: ak@suse.de
Cc: linux-kernel@vger.kernel.org, devel@openvz.org
Subject: [PATCH] x86_64: arch_pick_mmap_layout() fixlet
Date: Thu, 28 Jun 2007 12:45:05 +0400 [thread overview]
Message-ID: <20070628084505.GA11055@localhost.sw.ru> (raw)
sparse now warns about
arch/x86_64/mm/mmap.c:15:3: warning: returning void-valued expression
Generated code looks correct: there is jump to the end of
arch_pick_mmap_layout() after ia32_pick_mmap_layout(), but this should be fixed
regardless.
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---
arch/x86_64/mm/mmap.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--- a/arch/x86_64/mm/mmap.c
+++ b/arch/x86_64/mm/mmap.c
@@ -11,8 +11,10 @@
void arch_pick_mmap_layout(struct mm_struct *mm)
{
#ifdef CONFIG_IA32_EMULATION
- if (current_thread_info()->flags & _TIF_IA32)
- return ia32_pick_mmap_layout(mm);
+ if (current_thread_info()->flags & _TIF_IA32) {
+ ia32_pick_mmap_layout(mm);
+ return;
+ }
#endif
mm->mmap_base = TASK_UNMAPPED_BASE;
if (current->flags & PF_RANDOMIZE) {
reply other threads:[~2007-06-28 8:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070628084505.GA11055@localhost.sw.ru \
--to=adobriyan@sw.ru \
--cc=ak@suse.de \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox