* [PATCH] x86_64: arch_pick_mmap_layout() fixlet
@ 2007-06-28 8:45 Alexey Dobriyan
0 siblings, 0 replies; only message in thread
From: Alexey Dobriyan @ 2007-06-28 8:45 UTC (permalink / raw)
To: ak; +Cc: linux-kernel, devel
sparse now warns about
arch/x86_64/mm/mmap.c:15:3: warning: returning void-valued expression
Generated code looks correct: there is jump to the end of
arch_pick_mmap_layout() after ia32_pick_mmap_layout(), but this should be fixed
regardless.
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---
arch/x86_64/mm/mmap.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--- a/arch/x86_64/mm/mmap.c
+++ b/arch/x86_64/mm/mmap.c
@@ -11,8 +11,10 @@
void arch_pick_mmap_layout(struct mm_struct *mm)
{
#ifdef CONFIG_IA32_EMULATION
- if (current_thread_info()->flags & _TIF_IA32)
- return ia32_pick_mmap_layout(mm);
+ if (current_thread_info()->flags & _TIF_IA32) {
+ ia32_pick_mmap_layout(mm);
+ return;
+ }
#endif
mm->mmap_base = TASK_UNMAPPED_BASE;
if (current->flags & PF_RANDOMIZE) {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-06-28 8:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-28 8:45 [PATCH] x86_64: arch_pick_mmap_layout() fixlet Alexey Dobriyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox