Re: [patch-mm 00/28] High resolution timer updates and x86_64 support - V3

Andrew Morton
2007-06-28T10:40:56Z

On Thu, 28 Jun 2007 11:47:04 +0200 Andi Kleen <ak@suse.de> wrote:

> On Thursday 28 June 2007 11:42:33 Andrew Morton wrote:
>
> > > The patch set has been tested in the -hrt and -rt trees for quite a while
> > > and the initial problems have been sorted out. Thanks to the folks from the
> > > PowerTop project for testing and feedback.
> >
> > hrm. Looks like none of your testers have HPET_ID_LEGSUP hardware.
>
> AFAIK it's only on IBM Summit. You have such a box?

Intel Nocona SDV thing. Old.

> > btw, if you want to know why I go on and on about crappy commenting, try to
> > work out from the kernel source code what HPET_ID_LEGSUP is, and why it
> > gets special treatment. It is not possible. This is not maintainable
> > code.
>
> We have a reference somewhere to the HPET spec.

The HPET spec won't tell me why HPET_ID_LEGSUP hpets get a kmalloc in Linux
but the !HPET_ID_LEGSUP ones don't.