[PATCH] frv: fix fallout from "remove sched.h from mm.h" patch

[PATCH] frv: fix fallout from "remove sched.h from mm.h" patch

[Alexey Dobriyan]

Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---

 include/asm-frv/pgtable.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/include/asm-frv/pgtable.h
+++ b/include/asm-frv/pgtable.h
@@ -25,7 +25,7 @@
 #include <linux/slab.h>
 #include <linux/list.h>
 #include <linux/spinlock.h>
-struct mm_struct;
+#include <linux/sched.h>
 struct vm_area_struct;
 #endif
 

Re: [PATCH] frv: fix fallout from "remove sched.h from mm.h" patch

[Andrew Morton]

On Thu, 28 Jun 2007 18:09:21 +0400
Alexey Dobriyan <adobriyan@sw.ru> wrote:

> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
> ---
> 
>  include/asm-frv/pgtable.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/include/asm-frv/pgtable.h
> +++ b/include/asm-frv/pgtable.h
> @@ -25,7 +25,7 @@
>  #include <linux/slab.h>
>  #include <linux/list.h>
>  #include <linux/spinlock.h>
> -struct mm_struct;
> +#include <linux/sched.h>
>  struct vm_area_struct;
>  #endif
>  

Please provide changelogs.

I assume this patch fixes some build error or something.

Re: [PATCH] frv: fix fallout from "remove sched.h from mm.h" patch

[Robert P. J. Day]

On Thu, 28 Jun 2007, Andrew Morton wrote:

> On Thu, 28 Jun 2007 18:09:21 +0400
> Alexey Dobriyan <adobriyan@sw.ru> wrote:
>
> > Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
> > ---
> >
> >  include/asm-frv/pgtable.h |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/include/asm-frv/pgtable.h
> > +++ b/include/asm-frv/pgtable.h
> > @@ -25,7 +25,7 @@
> >  #include <linux/slab.h>
> >  #include <linux/list.h>
> >  #include <linux/spinlock.h>
> > -struct mm_struct;
> > +#include <linux/sched.h>
> >  struct vm_area_struct;
> >  #endif
> >
>
> Please provide changelogs.
>
> I assume this patch fixes some build error or something.

  i actually asked about this on either the janitors or newbies list
the other day -- one of the early examples from the LDD3 device
drivers book which built fine all this time suddenly stopped building,
until i explicitly included <linux/sched.h> to be able to dereference
a pointer to "task_struct":

/home/rpjday/AMD/k/topics/0_hi/hi1.c:15: error: dereferencing pointer to incomplete type
/home/rpjday/AMD/k/topics/0_hi/hi1.c:16: error: dereferencing pointer to incomplete type

  clearly, until now, that header file was being picked up
*somewhere*, but not now.  so i'm guessing there's going to be code
all over the place that suddenly needs to add that inclusion of
sched.h.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [PATCH] frv: fix fallout from "remove sched.h from mm.h" patch

[Alexey Dobriyan]

On Fri, Jun 29, 2007 at 09:10:52AM -0400, Robert P. J. Day wrote:
> On Thu, 28 Jun 2007, Andrew Morton wrote:
> > On Thu, 28 Jun 2007 18:09:21 +0400
> > Alexey Dobriyan <adobriyan@sw.ru> wrote:
> >
> > > Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
> > > ---
> > >
> > >  include/asm-frv/pgtable.h |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > --- a/include/asm-frv/pgtable.h
> > > +++ b/include/asm-frv/pgtable.h
> > > @@ -25,7 +25,7 @@
> > >  #include <linux/slab.h>
> > >  #include <linux/list.h>
> > >  #include <linux/spinlock.h>
> > > -struct mm_struct;
> > > +#include <linux/sched.h>
> > >  struct vm_area_struct;
> > >  #endif
> > >
> >
> > Please provide changelogs.
> >
> > I assume this patch fixes some build error or something.
>
>   i actually asked about this on either the janitors or newbies list
> the other day -- one of the early examples from the LDD3 device
> drivers book which built fine all this time suddenly stopped building,
> until i explicitly included <linux/sched.h> to be able to dereference
> a pointer to "task_struct":
>
> /home/rpjday/AMD/k/topics/0_hi/hi1.c:15: error: dereferencing pointer to incomplete type
> /home/rpjday/AMD/k/topics/0_hi/hi1.c:16: error: dereferencing pointer to incomplete type
>
>   clearly, until now, that header file was being picked up
> *somewhere*,

from include/linux/mm.h , yes

> but not now.

dammit!

> so i'm guessing there's going to be code
> all over the place that suddenly needs to add that inclusion of
> sched.h.

this is the last known to me bit of compile breakage that was caused by
commit e8edc6e03a5c8562dc70a6d969f732bdb355a7e7 aka
"[PATCH] Detach sched.h from mm.h"

And after you'll check diffstat and build current kernel for different archs
yourself, I hope you'll take that "all over the place" back.

P.S.: Al may know more because he is building different set of configs, but I
      was larted about frv only.

Re: [PATCH] frv: fix fallout from "remove sched.h from mm.h" patch

[Robert P. J. Day]

On Fri, 29 Jun 2007, Alexey Dobriyan wrote:

> On Fri, Jun 29, 2007 at 09:10:52AM -0400, Robert P. J. Day wrote:

> >   i actually asked about this on either the janitors or newbies
> > list the other day -- one of the early examples from the LDD3
> > device drivers book which built fine all this time suddenly
> > stopped building, until i explicitly included <linux/sched.h> to
> > be able to dereference a pointer to "task_struct":
> >
> > /home/rpjday/AMD/k/topics/0_hi/hi1.c:15: error: dereferencing pointer to incomplete type
> > /home/rpjday/AMD/k/topics/0_hi/hi1.c:16: error: dereferencing pointer to incomplete type
> >
> >   clearly, until now, that header file was being picked up
> > *somewhere*,
>
> from include/linux/mm.h , yes
>
> > but not now.
>
> dammit!
>
> > so i'm guessing there's going to be code all over the place that
> > suddenly needs to add that inclusion of sched.h.
>
> this is the last known to me bit of compile breakage that was caused by
> commit e8edc6e03a5c8562dc70a6d969f732bdb355a7e7 aka
> "[PATCH] Detach sched.h from mm.h"
>
> And after you'll check diffstat and build current kernel for
> different archs yourself, I hope you'll take that "all over the
> place" back.

i didn't mean code *in the kernel* necessarily, merely code
representing out-of-tree loadable drivers that will now need to
include sched.h that didn't need it before.  such as that very example
out of LDD3.

sorry that i wasn't more clear about that.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [PATCH] frv: fix fallout from "remove sched.h from mm.h" patch

[Andrew Morton]

On Fri, 29 Jun 2007 09:10:52 -0400 (EDT)
"Robert P. J. Day" <rpjday@mindspring.com> wrote:

> > Please provide changelogs.
> >
> > I assume this patch fixes some build error or something.

I am still awaiting a description of what this patch does.

>   i actually asked about this on either the janitors or newbies list
> the other day -- one of the early examples from the LDD3 device
> drivers book which built fine all this time suddenly stopped building,
> until i explicitly included <linux/sched.h> to be able to dereference
> a pointer to "task_struct":
> 
> /home/rpjday/AMD/k/topics/0_hi/hi1.c:15: error: dereferencing pointer to incomplete type
> /home/rpjday/AMD/k/topics/0_hi/hi1.c:16: error: dereferencing pointer to incomplete type

I'll proceed, assuming that the patch fixes the above build errors.