Re: [PATCH] ALSA: more section mismatches

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 28 Jun 2007 15:05:15 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix section mismatch warnings:
> 
> WARNING: sound/built-in.o(.exit.text+0x3ad): Section mismatch: reference to .init.text: (between 'sb_exit' and 'unload_uart6850')
> WARNING: sound/built-in.o(.exit.text+0x753): Section mismatch: reference to .init.text: (between 'snd_mts64_module_exit' and 'snd_portman_module_exit')
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  sound/drivers/mts64.c |    2 +-
>  sound/oss/sb_card.c   |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-2622-rc6.orig/sound/drivers/mts64.c
> +++ linux-2622-rc6/sound/drivers/mts64.c
> @@ -1048,7 +1048,7 @@ static struct platform_driver snd_mts64_
>  /*********************************************************************
>   * module init stuff
>   *********************************************************************/
> -static void __init_or_module snd_mts64_unregister_all(void)
> +static void snd_mts64_unregister_all(void)

Well this is called from __exit, so __init_or_module isn't right.  But we
don't have an __exit_or_module.

>  {
>  	int i;
>  
> --- linux-2622-rc6.orig/sound/oss/sb_card.c
> +++ linux-2622-rc6/sound/oss/sb_card.c
> @@ -290,7 +290,7 @@ static struct pnp_card_driver sb_pnp_dri
>  MODULE_DEVICE_TABLE(pnp_card, sb_pnp_card_table);
>  #endif /* CONFIG_PNP */
>  
> -static void __init_or_module sb_unregister_all(void)
> +static void sb_unregister_all(void)
>  {
>  #ifdef CONFIG_PNP
>  	if (pnp_registered)

One of these is alsa and the other isn't.

But what the heck: obviously safe, I'll slam it all in.