Re: [PATCH] Info dump on Oops or panic()

Kyle McMartin
2007-06-28T22:29:39Z

On Thu, Jun 28, 2007 at 03:05:56PM -0700, Joshua Wise wrote:
> --- a/arch/x86_64/kernel/process.c
> +++ b/arch/x86_64/kernel/process.c
> @@ -356,6 +356,7 @@ void show_regs(struct pt_regs *regs)
> printk("CPU %d:", smp_processor_id());
> __show_regs(regs);
> show_trace(NULL, regs, (void *)(regs + 1));
> + atomic_notifier_call_chain(&info_dumper_list, 0, NULL);
> }
>

woah woah woah. This could push critical bits of the register dump or
stacktrace off the screen... Barring any other problems with the patch,
this should probably be dumped in the oops header, not trailing it where
it could hide critical debugging info.

Regards,
Kyle M.