From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764782AbXF1RZp (ORCPT ); Thu, 28 Jun 2007 13:25:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759914AbXF1RZi (ORCPT ); Thu, 28 Jun 2007 13:25:38 -0400 Received: from ns2.suse.de ([195.135.220.15]:35424 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756936AbXF1RZh (ORCPT ); Thu, 28 Jun 2007 13:25:37 -0400 Date: Thu, 28 Jun 2007 19:25:14 +0200 From: Stefan Seyfried To: "Rafael J. Wysocki" Cc: Pavel Machek , nigel@nigel.suspend2.net, linux-kernel@vger.kernel.org, suspend-devel@lists.sourceforge.net, Linus Torvalds Subject: Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND Message-ID: <20070628172514.GA12770@suse.de> References: <20070628135108.GA1810@elf.ucw.cz> <200706281734.54642.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200706281734.54642.rjw@sisk.pl> X-Operating-System: openSUSE 10.3 (i586) Alpha5, Kernel 2.6.22-rc4-git6-2-default User-Agent: mutt-ng/devel-r804 (Linux) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org (CC'ing Linus, since disabling consoles during suspend was his idea IIRC) On Thu, Jun 28, 2007 at 05:34:54PM +0200, Rafael J. Wysocki wrote: > Hi, > > On Thursday, 28 June 2007 15:51, Pavel Machek wrote: > > Hi! > > > > What about this? (Only compile tested, but looks pretty obvious to > > me). Something like this should get us rid of ugly option, and still > > solve debugging problems... Hmmm? > > Pavel > > > > Kill CONFIG_DISABLE_CONSOLE_SUSPEND; it should not be configurable at > > all, instead, we should automatically keep console alive when > > possible. > > > > Signed-off-by: Pavel Machek > > > > diff --git a/drivers/char/lp.c b/drivers/char/lp.c > > index 62051f8..8267ff8 100644 > > --- a/drivers/char/lp.c > > +++ b/drivers/char/lp.c > > @@ -144,7 +144,7 @@ static unsigned int lp_count = 0; > > static struct class *lp_class; > > > > #ifdef CONFIG_LP_CONSOLE > > -static struct parport *console_registered; // initially NULL > > +static struct parport *console_registered; > > #endif /* CONFIG_LP_CONSOLE */ > > Could you please avoid fixing things like this, white space etc. in this patch? > It would be easier to read ... Yes. > I generally agree with the idea, but the patch needs a clean up, IMHO. However, we don't know which consoles are safe to stay alive during suspend. Generally, defaulting to suspending them all is not a bad idea IMHO. And IIRC it is plain luck if a serial console survives the suspend (or was the serial code fixed recently?) So i do not care too much, but my / Frank's patch was shorter :-) and safer. -- Stefan Seyfried QA / R&D Team Mobile Devices | "Any ideas, John?" SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out." This footer brought to you by insane German lawmakers: SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)