From: Kyle McMartin <kyle@mcmartin.ca>
To: Joshua Wise <jwise@google.com>
Cc: linux-kernel@vger.kernel.org, akpm@google.com,
thockin@google.com, mikew@google.com, masouds@google.com
Subject: Re: [PATCH] Info dump on Oops or panic()
Date: Thu, 28 Jun 2007 18:18:35 -0400 [thread overview]
Message-ID: <20070628221835.GI2784@fattire.cabal.ca> (raw)
In-Reply-To: <Pine.LNX.4.64.0706281502350.617@internets.corp.google.com>
On Thu, Jun 28, 2007 at 03:05:56PM -0700, Joshua Wise wrote:
> --- a/arch/x86_64/kernel/process.c
> +++ b/arch/x86_64/kernel/process.c
> @@ -356,6 +356,7 @@ void show_regs(struct pt_regs *regs)
> printk("CPU %d:", smp_processor_id());
> __show_regs(regs);
> show_trace(NULL, regs, (void *)(regs + 1));
> + atomic_notifier_call_chain(&info_dumper_list, 0, NULL);
> }
>
woah woah woah. This could push critical bits of the register dump or
stacktrace off the screen... Barring any other problems with the patch,
this should probably be dumped in the oops header, not trailing it where
it could hide critical debugging info.
Regards,
Kyle M.
next prev parent reply other threads:[~2007-06-28 22:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-28 22:05 [PATCH] Info dump on Oops or panic() Joshua Wise
2007-06-28 22:18 ` Kyle McMartin [this message]
2007-06-28 23:12 ` [PATCH] [revised -- version 2] " Joshua Wise
2007-06-28 23:48 ` Andrew Morton
2007-06-29 2:15 ` Joshua Wise
2007-06-28 23:54 ` [PATCH] " Mike Frysinger
2007-06-29 0:39 ` Jiri Kosina
2007-06-29 2:01 ` Andrew Morton
2007-06-29 1:15 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070628221835.GI2784@fattire.cabal.ca \
--to=kyle@mcmartin.ca \
--cc=akpm@google.com \
--cc=jwise@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masouds@google.com \
--cc=mikew@google.com \
--cc=thockin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox