public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: clameter@sgi.com, hugh@veritas.com, James.Bottomley@steeleye.com,
	rmk+lkml@arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Containment measures for slab objects on scatter gather lists
Date: Thu, 28 Jun 2007 22:45:19 -0700	[thread overview]
Message-ID: <20070628224519.1a3319c3.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070628.223734.21928089.davem@davemloft.net>

On Thu, 28 Jun 2007 22:37:34 -0700 (PDT) David Miller <davem@davemloft.net> wrote:

> From: Andrew Morton <akpm@linux-foundation.org>
> Date: Thu, 28 Jun 2007 22:24:24 -0700
> 
> > So what happens when two quite different threads of control are doing
> > IO against two hunks of kmalloced memory which happen to come from the same
> > page?  Either some (kernel-wide) locking is needed, or that pageframe needs
> > to be treated as readonly?
> 
> Or you put an atomic_t at the beginning or tail of every SLAB
> object.  It's a space cost not a runtime cost for the common
> case which is:
> 
> 	smp_rmb();
> 	if (atomic_read(&slab_obj->count) == 1)
> 		really_free_it();
> 	else if (atomic_dec_and_test(...))
> 
> Note I don't like this variant either. :)

but, but...  Christoph said 'The dma layer may then perform operations on
the "slab page'.

If those operations involve modifying that slab page's pageframe then what
stops concurrent dma'ers from stomping on each other's changes?  As in:
why aren't we already buggy?

If those operations _don't_ involve modifying the pageframe (hopes this is
true) then we're read-only and things become much easier?

  reply	other threads:[~2007-06-29  5:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-29  4:01 [PATCH] Containment measures for slab objects on scatter gather lists Christoph Lameter
2007-06-29  4:10 ` David Miller
2007-06-29  4:22   ` Christoph Lameter
2007-06-29  4:28     ` David Miller
2007-06-29  4:39       ` Christoph Lameter
2007-06-29  5:06         ` David Miller
2007-06-29  5:24           ` Andrew Morton
2007-06-29  5:37             ` David Miller
2007-06-29  5:45               ` Andrew Morton [this message]
2007-06-29  6:51                 ` Christoph Lameter
2007-06-29 12:16                 ` Alan Cox
2007-06-29 20:45                   ` Andrew Morton
2007-06-29 21:14                     ` Russell King
2007-06-29 23:11                       ` Alan Cox
2007-06-30  7:54                         ` Russell King
2007-06-29 22:39                     ` Alan Cox
2007-06-29  6:50               ` Christoph Lameter
2007-06-30  8:49             ` Christoph Hellwig
2007-06-29  7:00           ` Christoph Lameter
2007-06-29  9:06             ` David Miller
2007-06-29 13:04 ` Hugh Dickins
2007-06-29 14:15   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070628224519.1a3319c3.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=James.Bottomley@steeleye.com \
    --cc=clameter@sgi.com \
    --cc=davem@davemloft.net \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox