From: Stefan Seyfried <seife@suse.de>
To: Nigel Cunningham <nigel@nigel.suspend2.net>
Cc: Pavel Machek <pavel@ucw.cz>, LKML <linux-kernel@vger.kernel.org>,
Rafael Wysocki <rjw@sisk.pl>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Optional Beeping During Resume From Suspend To Ram.
Date: Fri, 29 Jun 2007 20:03:44 +0200 [thread overview]
Message-ID: <20070629180344.GA17907@suse.de> (raw)
In-Reply-To: <200706290827.13024.nigel@nigel.suspend2.net>
On Fri, Jun 29, 2007 at 08:27:12AM +1000, Nigel Cunningham wrote:
> > Can we rename/reuse existing flag variable?
>
> Sorry, but I can't resist the opportunity to say "Send a patch!" :)
>
> Seriously, though, I'd prefer not to. If we rename that acpi video flags
> variable (I assume this is what you're thinking of), we only create cause for
> confusion. A variable should for debugging or for controlling quirks, not for
> both at the same time.
I agree. And video_flags is something totally different :-)
I just used that one in my ad-hoc hack (which actually was only to illustrate
the idea) because a) it was enough to show the intent and b) i did not know
how to do it better ;-)
--
Stefan Seyfried
QA / R&D Team Mobile Devices | "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out."
This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
next prev parent reply other threads:[~2007-06-29 18:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 11:18 [PATCH] Optional Beeping During Resume From Suspend To Ram Nigel Cunningham
2007-06-19 21:33 ` Rafael J. Wysocki
2007-06-20 22:09 ` Rafael J. Wysocki
2007-06-20 22:24 ` Nigel Cunningham
2007-06-21 21:20 ` Rafael J. Wysocki
2007-06-28 14:25 ` Pavel Machek
2007-06-28 22:27 ` Nigel Cunningham
2007-06-29 18:03 ` Stefan Seyfried [this message]
2007-06-29 22:35 ` Pavel Machek
2007-06-30 10:15 ` Rafael J. Wysocki
2007-06-30 10:11 ` Pavel Machek
2007-06-30 20:30 ` Rafael J. Wysocki
2007-07-04 21:29 ` Pavel Machek
2007-07-04 21:50 ` Rafael J. Wysocki
2007-07-04 22:46 ` Pavel Machek
2007-07-05 19:03 ` Rafael J. Wysocki
2007-07-05 22:32 ` Pavel Machek
2007-07-04 22:34 ` Nigel Cunningham
2007-07-04 22:48 ` Pavel Machek
2007-07-04 22:56 ` Nigel Cunningham
2007-07-04 23:01 ` Pavel Machek
2007-07-04 23:10 ` Nigel Cunningham
2007-07-04 23:25 ` Pavel Machek
2007-07-05 18:43 ` Rafael J. Wysocki
2007-07-05 22:37 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070629180344.GA17907@suse.de \
--to=seife@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nigel@nigel.suspend2.net \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox