From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Grant Likely <grant.likely@secretlab.ca>
Subject: [PATCH 2/4 -mm] void unregister_blkdev - delete redundant message
Date: Sat, 30 Jun 2007 12:13:22 +0900 [thread overview]
Message-ID: <20070630031322.GE4045@APFDCB5C> (raw)
In-Reply-To: <20070630031212.GD4045@APFDCB5C>
No need to warn unregister_blkdev() failure by caller.
(The previous patch makes unregister_blkdev() print error message in
error case)
Cc: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
drivers/block/xsysace.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: 2.6-mm/drivers/block/xsysace.c
===================================================================
--- 2.6-mm.orig/drivers/block/xsysace.c
+++ 2.6-mm/drivers/block/xsysace.c
@@ -1157,9 +1157,7 @@ static void __exit ace_exit(void)
{
pr_debug("Unregistering Xilinx SystemACE driver\n");
driver_unregister(&ace_driver);
- if (unregister_blkdev(ace_major, "xsysace"))
- printk(KERN_WARNING "systemace unregister_blkdev(%i) failed\n",
- ace_major);
+ unregister_blkdev(ace_major, "xsysace");
}
module_init(ace_init);
next prev parent reply other threads:[~2007-06-30 3:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-30 3:10 [PATCH 1/4] void unregister_blkdev - do WARN_ON failure Akinobu Mita
2007-06-30 3:12 ` [PATCH 2/4] void unregister_blkdev - delete redundant messages Akinobu Mita
2007-06-30 3:13 ` Akinobu Mita [this message]
2007-06-30 6:15 ` [PATCH 2/4 -mm] void unregister_blkdev - delete redundant message Grant Likely
2007-06-30 6:14 ` [PATCH 2/4] void unregister_blkdev - delete redundant messages Grant Likely
2007-06-30 14:08 ` Akinobu Mita
2007-06-30 14:12 ` Grant Likely
2007-06-30 3:15 ` [PATCH 3/4] void unregister_blkdev - ignore the return value Akinobu Mita
2007-06-30 3:17 ` [PATCH 4/4] void unregister_blkdev - make void Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070630031322.GE4045@APFDCB5C \
--to=akinobu.mita@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox