public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] LinuxPPS (with new syscalls API) - new version
Date: Sat, 30 Jun 2007 09:38:27 +0100	[thread overview]
Message-ID: <20070630083827.GA21102@infradead.org> (raw)
In-Reply-To: <20070628161450.GD13886@enneenne.com>

On Thu, Jun 28, 2007 at 06:14:50PM +0200, Rodolfo Giometti wrote:
> Hello,
> 
> here my new LinuxPPS patch.
> 
> What to do now for kernel inclusion? Should I provide several patches?
> If so how should I divide them?
> 
> Thanks a lot,

Sorry for coming in that late, but using syscalls for something as
periphal sounds like a very bad idea to me, and the syscalls aren't
defined nicely either (e.g. you have an ioctl lookalike).  I'd say
back to the drawingboard.

And yes, even ioctls are nicer than badly designed syscalls :)

Also code seems to be odd at least in a few places, e.g. all the access_oks
and double checks of the ioctl-lookalike commands should go.

  parent reply	other threads:[~2007-06-30  8:38 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-26 10:06 [PATCH] LinuxPPS (with new syscalls API) Rodolfo Giometti
2007-06-26 10:57 ` David Woodhouse
2007-06-26 17:06   ` Rodolfo Giometti
2007-06-26 17:38     ` David Woodhouse
2007-06-26 18:13       ` Rodolfo Giometti
2007-06-26 18:20         ` David Woodhouse
2007-06-27 10:14       ` Rodolfo Giometti
2007-06-27 10:18         ` David Woodhouse
2007-06-27 12:58           ` Rodolfo Giometti
2007-06-27 16:11             ` David Woodhouse
2007-06-27 17:45               ` Rodolfo Giometti
2007-06-27 17:49                 ` David Woodhouse
2007-06-27 22:46                   ` Rodolfo Giometti
2007-06-28  8:08                     ` David Woodhouse
2007-06-28  8:15                       ` Rodolfo Giometti
2007-06-28  8:31                         ` David Woodhouse
2007-06-28  8:40                           ` Rodolfo Giometti
2007-06-28 11:44                             ` David Woodhouse
2007-06-28 14:15                               ` Rodolfo Giometti
2007-06-28 16:14                               ` [PATCH] LinuxPPS (with new syscalls API) - new version Rodolfo Giometti
2007-06-29 11:38                                 ` David Woodhouse
2007-06-29 15:08                                   ` Rodolfo Giometti
2007-06-29 15:25                                     ` David Woodhouse
2007-06-29 15:38                                       ` Rodolfo Giometti
2007-06-29 15:41                                         ` David Woodhouse
2007-06-29 16:23                                           ` Rodolfo Giometti
2007-06-29 16:23                                             ` David Woodhouse
2007-06-29 16:36                                               ` Rodolfo Giometti
2007-06-29 16:38                                                 ` David Woodhouse
2007-06-29 15:55                                     ` David Woodhouse
2007-06-29 16:34                                       ` Rodolfo Giometti
2007-06-29 16:40                                         ` David Woodhouse
2007-06-30 17:13                                           ` Rodolfo Giometti
2007-07-01  7:13                                             ` Stephen Rothwell
2007-07-01 19:24                                               ` Rodolfo Giometti
2007-07-10 16:01                                                 ` Lennart Sorensen
2007-07-10 16:36                                                   ` Rodolfo Giometti
2007-07-10 16:36                                                     ` David Woodhouse
2007-07-10 16:44                                                       ` Rodolfo Giometti
2007-07-10 22:03                                                     ` Lennart Sorensen
2007-07-11  8:06                                                       ` Rodolfo Giometti
2007-07-11 15:22                                                         ` Lennart Sorensen
2007-07-11 16:32                                                           ` Rodolfo Giometti
2007-07-11  1:18                                                   ` Roman Zippel
2007-07-11 15:24                                                     ` Lennart Sorensen
2007-07-11 16:35                                                       ` Rodolfo Giometti
2007-07-11 17:34                                                       ` Roman Zippel
2007-07-01 12:03                                             ` David Woodhouse
2007-07-01 19:27                                               ` Rodolfo Giometti
2007-07-03  9:48                                               ` Rodolfo Giometti
2007-07-03 13:09                                                 ` David Woodhouse
2007-07-03 13:21                                                   ` Rodolfo Giometti
2007-07-09 13:19                                                   ` Rodolfo Giometti
2007-07-10 16:05                                                     ` David Woodhouse
2007-07-10 16:38                                                       ` Rodolfo Giometti
2007-07-11  9:17                                                         ` David Woodhouse
2007-07-11 10:46                                                           ` Rodolfo Giometti
2007-06-30  8:38                                 ` Christoph Hellwig [this message]
2007-06-30 17:06                                   ` Rodolfo Giometti
2007-07-08  9:05                                 ` Oleg Verych
2007-07-09  9:16                                   ` Rodolfo Giometti
2007-07-09 10:56                                     ` Makefiles for GNU make (Re: [PATCH] LinuxPPS (with new syscalls API) - new version) Oleg Verych
2007-07-09 10:57                                       ` Rodolfo Giometti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070630083827.GA21102@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=dwmw2@infradead.org \
    --cc=giometti@enneenne.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox