Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM

Jeff Dike
2007-06-28T22:45:40Z

On Thu, Jun 28, 2007 at 11:25:37PM +0100, Alan Cox wrote:
> This completely bogus. readb() should be present on M68K, fix the
> platform to implement readb() for MMIO, even if your MMIO readb is a
> moveb instruction.
>
> check_signature is relevant for anything with MMIO space (for example you
> can legitimately want to check_signature a MAC68K Nubus ROM).
>
> S/390 is a bit of a special case as no S/390 usage of check_signature
> appears sane but equally it isn't used so you can stub it out.

This is a problem for UML too.

I have a patch in my tree, which basically stubs readb, waiting to see
how this is fixed for the other arches.

Jeff

--
Work email - jdike at linux dot intel dot com