Re: [-mm patch] fix duplicate CONFIG_DMAR Makefile line

Keshavamurthy, Anil S
2007-07-03T00:36:00Z

On Sun, Jul 01, 2007 at 10:22:43PM +0200, Adrian Bunk wrote:
> On Thu, Jun 28, 2007 at 03:43:21AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.22-rc4-mm2:
> >...
> > +intel-iommu-intel-iommu-driver.patch
> >...
> > Intel IOMMU support
> >...
>
>
> Contrary to popular belief, two identical Makefile lines don't bring any
> advantages. ;-)
:). Thanks for the fix.

>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>

>
> ---
> --- linux-2.6.22-rc6-mm1/drivers/pci/Makefile.old 2007-06-30 03:33:54.000000000 +0200
> +++ linux-2.6.22-rc6-mm1/drivers/pci/Makefile 2007-06-30 03:34:04.000000000 +0200
> @@ -23,9 +23,6 @@
> # Build Intel IOMMU support
> obj-$(CONFIG_DMAR) += dmar.o iova.o intel-iommu.o
>
> -#Build Intel-IOMMU support
> -obj-$(CONFIG_DMAR) += iova.o dmar.o intel-iommu.o
> -
> #
> # Some architectures use the generic PCI setup functions
> #