Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM

Roman Zippel
2007-06-28T22:51:32Z

Hi,

On Thu, 28 Jun 2007, Alan Cox wrote:

> > check_signature() needs readb() but with some setups (s390, m68k allmodconfig)
> > there is no implementation of readb. This causes build errors with
> > -Werror-implicit-function-declaration.
>
> This completely bogus. readb() should be present on M68K, fix the
> platform to implement readb() for MMIO, even if your MMIO readb is a
> moveb instruction.
>
> check_signature is relevant for anything with MMIO space (for example you
> can legitimately want to check_signature a MAC68K Nubus ROM).

A generic check_signature() is a little difficult if we have separate io
functions for every bus.

bye, Roman