Re: [PATCH 2.6.22-rc6-mm1] compile error when CONFIG_DM_NETLINK is not defined

Alasdair G Kergon
2007-06-28T15:37:42Z

On Thu, Jun 28, 2007 at 09:49:17AM -0500, Dave Kleikamp wrote:
> I got this compile error:
> LD drivers/md/built-in.o
> drivers/md/dm-multipath.o: In function `dm_path_event':
> drivers/md/dm-netlink.h:56: multiple definition of `dm_path_event'
> drivers/md/dm-mod.o:drivers/md/dm-netlink.h:56: first defined here
> drivers/md/dm-multipath.o: In function `dm_netlink_send_events':
> drivers/md/dm-netlink.h:51: multiple definition of `dm_netlink_send_events'
> drivers/md/dm-mod.o:drivers/md/dm-netlink.h:51: first defined here
> make[2]: *** [drivers/md/built-in.o] Error 1
>
> I was able to fix it by making the dummy inline functions static.
>
> Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>

Sorry for that - I've added your fix to dm-netlink-add-to-core.patch.
Of course I forgot to test with the new option disabled:-(

Alasdair
--
agk@redhat.com