Re: 2.6.22-rc6-mm1

Sergei Shtylyov
2007-07-02T14:21:42Z

Hello.

Jason Wessel wrote:

>>> allmodconfig on powerpc (iMac g3) fails due to
>>> git-kgdb.patch. allmodconfig defaults should be changed?

>>> CC arch/powerpc/kernel/kgdb.o
>>> arch/powerpc/kernel/kgdb.c:485:2: error: #error Both XMON and KGDB
>>> selected in .config. Unselect one of them.
>>> make[1]: *** [arch/powerpc/kernel/kgdb.o] Blad 1
>>> make: *** [arch/powerpc/kernel] Blad 2

>> I'm not sure if this will work out but maybe it's worth to disable
>> XMON if KGDB is selected, like this?
>> config XMON
>> bool "Include xmon kernel debugger"
>> depends on DEBUGGER && !KGDB

> It did not seem that you can make a radio button / multi-select kernel
> config option unless the options are in the same Kconfig file. Given
> that xmon and kgdb are mutually exclusive at the moment.

> What Sergei mentioned is the fix that needs to be used for the time being.
> Attached is the patch I put in the for_mm branch in the linux-2.6-kgdb
> git tree.

> Jason.

> ------------------------------------------------------------------------

> xmon_or_kgdb.patch

> From: Jason Wessel <jason.wessel@windriver.com>
> Subject: [PATCH] Turn off xmon if kgdb is active on ppc and powerpc

> Xmon and kgdb are mutuall exclusive at the moment so xmon should be
> turned off in the kernel config options if kgdb selected. The case with "make allmodconfig" was failing and this patch addresses the problem.

> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>

> ---
> arch/powerpc/Kconfig.debug | 2 +-
> arch/ppc/Kconfig.debug | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)

This patch does not seem complete as the #error that was tiggering has not
been deleleted from arch/powerpc/kernel/kgdb.c (and not it's useless)

WBR, Sergei