2.6.22-rc6-mm1: SLUB_DEBUG=n compile error

Adrian Bunk
2007-07-07T01:50:00Z

On Thu, Jun 28, 2007 at 03:43:21AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.22-rc4-mm2:
>...
> +slub-add-some-more-inlines-and-ifdef-config_slub_debug.patch
>...
> slub/slab/slob updates
>...

Tip of the day:
Also test the compilation of the configuration you are changing.

With CONFIG_SLUB_DEBUG=n:

<-- snip -->

...
CC mm/slub.o
/home/bunk/linux/kernel-2.6/linux-2.6.22-rc6-mm1/mm/slub.c: In function ‘init_kmem_cache_node’:
/home/bunk/linux/kernel-2.6/linux-2.6.22-rc6-mm1/mm/slub.c:1873: error: ‘struct kmem_cache_node’ has no member named ‘full’
...
make[2]: *** [mm/slub.o] Error 1

<-- snip -->

Another problem with this patch are the added inline's:

gcc already automatically inlines static functions with only one caller,
and decides for other static functions based on the size of the function.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed