Re: [patch -mm] Make check_signature() depend on CONFIG_HAS_IOMEM

Roman Zippel
2007-06-29T00:06:33Z

Hi,

On Fri, 29 Jun 2007, Alan Cox wrote:

> > > check_signature is relevant for anything with MMIO space (for example you
> > > can legitimately want to check_signature a MAC68K Nubus ROM).
> >
> > A generic check_signature() is a little difficult if we have separate io
> > functions for every bus.
>
> Does M68K implement iomap() and pci_iomap and friends yet ?

How is that related?

> check_signature has fairly few users so moving to be iomap based wouldn't
> be hard if that was a problem. The other option would seem to be
> bus->check_signature() ?

IMO the first question would be whether that function is really this
important. We can also just leave it as a PCI/ISA template and other bus
specific header can implement when necessary.

bye, Roman