From: Andi Kleen <ak@suse.de>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: blink driver power saving
Date: Sun, 1 Jul 2007 23:26:29 +0200 [thread overview]
Message-ID: <200707012326.29974.ak@suse.de> (raw)
In-Reply-To: <20070701125035.3f54d8b0@oldman>
On Sunday 01 July 2007 18:50:35 Stephen Hemminger wrote:
> The blink driver wakes up every jiffies which wastes power unnecessarily.
> Using a notifier gives same effect. Also add ability to unload module.
It's really a debugging tool where you normally don't care about
details like this. I wrote it to get visual feedback during kdump,
but it is nothing you should ever run during normal operation.
But I don't get how your patch is supposed to work. The blink driver
is not supposed to blink after panic -- panic does that anyways --
but always. So hooking it into the panic notifier chain which
is only called on panic makes about zero sense.
If it's really needed to fix the wakeup issue the interface to
the keyboard blinking would need to be changed.
-Andi
next prev parent reply other threads:[~2007-07-01 21:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 16:50 blink driver power saving Stephen Hemminger
2007-07-01 18:07 ` Linus Torvalds
2007-07-01 21:29 ` Andi Kleen
2007-07-01 22:14 ` Linus Torvalds
2007-07-01 23:59 ` Andi Kleen
2007-07-02 15:51 ` Linus Torvalds
2007-07-02 16:59 ` Alan Cox
2007-07-02 17:50 ` Stephen Hemminger
2007-07-02 19:03 ` Dmitry Torokhov
2007-07-02 19:08 ` Andi Kleen
2007-07-02 23:18 ` Pavel Machek
2007-07-01 21:26 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-07-02 11:43 Indan Zupancic
2007-07-02 11:51 ` Andi Kleen
2007-07-02 12:29 ` Indan Zupancic
2007-07-02 12:31 ` Dmitry Torokhov
2007-07-02 12:39 ` Andi Kleen
2007-07-02 12:56 ` Bernhard Walle
2007-07-02 13:42 ` Dmitry Torokhov
2007-07-02 13:43 ` Dmitry Torokhov
2007-07-02 20:19 ` Bernhard Walle
2007-07-04 21:47 ` Pavel Machek
2007-07-05 5:25 ` Dmitry Torokhov
2007-07-02 23:08 ` Pavel Machek
2007-07-03 5:42 ` Dmitry Torokhov
2007-07-04 21:40 ` Pavel Machek
2007-07-04 21:57 ` Pavel Machek
2007-07-04 22:11 ` Pavel Machek
2007-07-05 5:38 ` Dmitry Torokhov
2007-07-12 9:10 ` Pavel Machek
2007-07-13 0:42 ` Jiri Kosina
2007-07-04 22:32 ` Pavel Machek
2007-07-04 22:46 ` Linus Torvalds
2007-07-04 22:59 ` Pavel Machek
[not found] ` <alpine.LFD.0.98.0707041610530.9434@woody.linux-foundation.org>
2007-07-04 23:20 ` Pavel Machek
2007-07-03 7:12 ` Bernhard Walle
2007-07-04 19:37 ` Pavel Machek
2007-07-05 20:30 ` Bill Davidsen
[not found] <8CaWr-2o4-19@gated-at.bofh.it>
[not found] ` <8Cfjl-PJ-33@gated-at.bofh.it>
[not found] ` <8CfW1-1TX-23@gated-at.bofh.it>
[not found] ` <8ChEo-4yy-1@gated-at.bofh.it>
2007-07-02 13:11 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707012326.29974.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox