From: Marc Pignat <marc.pignat@hevs.ch>
To: Nicolas Ferre <nicolas.ferre@rfo.atmel.com>
Cc: Pierre Ossman <drzeus@drzeus.cx>,
ARM Linux Mailing List <linux-arm-kernel@lists.arm.linux.org.uk>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Victor <andrew@sanpeople.com>,
Andreas Beier <mughat@gmail.com>,
Hamish Guthrie <hamish@prodigi.ch>,
wux@landicorp.com,
Patrice Vilchez <patrice.vilchez@rfo.atmel.com>
Subject: Re: [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts
Date: Mon, 2 Jul 2007 14:45:13 +0200 [thread overview]
Message-ID: <200707021445.14316.marc.pignat@hevs.ch> (raw)
In-Reply-To: <4688EC94.1090901@rfo.atmel.com>
On Monday 02 July 2007 14:16, Nicolas Ferre wrote:
> Fixes hanging using multi block operations (seen during CMD25).
> Signed-off-by: Nicolas Ferre <nicolas.ferre@rfo.atmel.com>
Verified working on at91rm9200 using 1 wire mode.
A small remark, only for future improvements:
> @@ -817,7 +834,11 @@ static int __init at91_mci_probe(struct
>
> mmc->ops = &at91_mci_ops;
> mmc->f_min = 375000;
> - mmc->f_max = 25000000;
> + if (cpu_is_at91sam9263())
> + mmc->f_max = 50000000;
> + else
> + mmc->f_max = 25000000;
for at91rm9200 f_max is MCK/2 why don't use it?
Nice work, thanks
Regards
Marc
next prev parent reply other threads:[~2007-07-02 12:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-02 12:16 [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts Nicolas Ferre
2007-07-02 12:45 ` Marc Pignat [this message]
2007-07-02 13:32 ` Pierre Ossman
2007-07-09 10:51 ` Pierre Ossman
2007-07-09 12:48 ` Nicolas Ferre
2007-07-02 19:13 ` Mariusz Kozlowski
2007-07-09 12:58 ` Nicolas Ferre
2007-07-09 16:27 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707021445.14316.marc.pignat@hevs.ch \
--to=marc.pignat@hevs.ch \
--cc=andrew@sanpeople.com \
--cc=drzeus@drzeus.cx \
--cc=hamish@prodigi.ch \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mughat@gmail.com \
--cc=nicolas.ferre@rfo.atmel.com \
--cc=patrice.vilchez@rfo.atmel.com \
--cc=wux@landicorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox