From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757818AbXGBWsQ (ORCPT ); Mon, 2 Jul 2007 18:48:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754855AbXGBWsG (ORCPT ); Mon, 2 Jul 2007 18:48:06 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:54733 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754957AbXGBWsF (ORCPT ); Mon, 2 Jul 2007 18:48:05 -0400 Date: Mon, 2 Jul 2007 15:47:53 -0700 From: Andrew Morton To: Juan Antonio Martinez Cc: linux-kernel@vger.kernel.org Subject: Re: ppdev - libieee1284.so conflicts with 2.6.21 Message-Id: <20070702154753.56d06f10.akpm@linux-foundation.org> In-Reply-To: <1183368129.4967.1.camel@drake.micasa.es> References: <1183368129.4967.1.camel@drake.micasa.es> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Jul 2007 11:22:09 +0200 Juan Antonio Martinez wrote: > I've reported this error to Fedora Bugzilla: > > http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246406 > > In sort: to use libieee1284 I need to disable ppdev usage with > kernel 2.6.21. Kernel 2.6.20 works fine > > [root@drake char]# uname -a > Linux drake.micasa.es 2.6.21-1.3228.fc7 #1 SMP Tue Jun 12 15:37:31 EDT > 2007 i686 athlon i386 GNU/Linux > > By doing "echo disallow method ppdev > /etc/ieee1284.conf" everything > works fine on both kernels > > Seems affect several distributions, not Fedora specific: > http://bugs.archlinux.org/task/7438 > http://sourceforge.net/tracker/index.php?func=detail&aid=1739643&group_id=29314&atid=395778 > http://www.digipedia.pl/man/libieee1284.3.html > > Not sure if a kernel bug or a library one, so my apologizes if > this is not the propper list > Not much has changed in ppdev.c. Possibly this: commit da6752964290567a6b4ea180d1becda75e810e87 Author: David Brownell Date: Tue May 8 00:27:42 2007 -0700 layered parport code uses parport->dev Update some of the layered parport_driver code to use parport->dev: - i2c-parport (parent of i2c_adapter) - spi_butterfly (parent of spi_master, allowing cruft removal) - lp (creating class_device) - ppdev (parent of parportN device) - tipar (creating class_device) There are still drivers that should be updated, like some of the input drivers; but they won't be any worse off than they are today. broke something. Can you test a kernel with this change applied? --- a/drivers/char/ppdev.c~a +++ a/drivers/char/ppdev.c @@ -751,7 +751,7 @@ static const struct file_operations pp_f static void pp_attach(struct parport *port) { - device_create(ppdev_class, port->dev, MKDEV(PP_MAJOR, port->number), + device_create(ppdev_class, NULL, MKDEV(PP_MAJOR, port->number), "parport%d", port->number); } _