From: Andi Kleen <ak@suse.de>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: blink driver power saving
Date: Mon, 2 Jul 2007 21:08:43 +0200 [thread overview]
Message-ID: <200707022108.43293.ak@suse.de> (raw)
In-Reply-To: <20070702105000.73e50500@freepuppy.localdomain.hemminger.net>
On Monday 02 July 2007 19:50:00 Stephen Hemminger wrote:
> The patch makes sense. You don't need to poll every jiffie to find
> out if system has panic.
The blink driver doesn't run on panic (or at least not on panic on
the same kernel). It runs always. It was designed to do the blinking
while the kdump kernel runs and writes the dump.
> But I agree with Linus, it is the kind
> of patch that doesn't belong in the mainline kernel. Every developer
> seems to have built up a set of crappy/fragile debug tools, but these
> don't belong in the wild.
Would you argue then that kdump also doesn't belong into the kernel?
The patch was designed to plug a hole in kdump (no visual feedback)
-Andi
next prev parent reply other threads:[~2007-07-02 19:08 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 16:50 blink driver power saving Stephen Hemminger
2007-07-01 18:07 ` Linus Torvalds
2007-07-01 21:29 ` Andi Kleen
2007-07-01 22:14 ` Linus Torvalds
2007-07-01 23:59 ` Andi Kleen
2007-07-02 15:51 ` Linus Torvalds
2007-07-02 16:59 ` Alan Cox
2007-07-02 17:50 ` Stephen Hemminger
2007-07-02 19:03 ` Dmitry Torokhov
2007-07-02 19:08 ` Andi Kleen [this message]
2007-07-02 23:18 ` Pavel Machek
2007-07-01 21:26 ` Andi Kleen
-- strict thread matches above, loose matches on Subject: below --
2007-07-02 11:43 Indan Zupancic
2007-07-02 11:51 ` Andi Kleen
2007-07-02 12:29 ` Indan Zupancic
2007-07-02 12:31 ` Dmitry Torokhov
2007-07-02 12:39 ` Andi Kleen
2007-07-02 12:56 ` Bernhard Walle
2007-07-02 13:42 ` Dmitry Torokhov
2007-07-02 13:43 ` Dmitry Torokhov
2007-07-02 20:19 ` Bernhard Walle
2007-07-04 21:47 ` Pavel Machek
2007-07-05 5:25 ` Dmitry Torokhov
2007-07-02 23:08 ` Pavel Machek
2007-07-03 5:42 ` Dmitry Torokhov
2007-07-04 21:40 ` Pavel Machek
2007-07-04 21:57 ` Pavel Machek
2007-07-04 22:11 ` Pavel Machek
2007-07-05 5:38 ` Dmitry Torokhov
2007-07-12 9:10 ` Pavel Machek
2007-07-13 0:42 ` Jiri Kosina
2007-07-04 22:32 ` Pavel Machek
2007-07-04 22:46 ` Linus Torvalds
2007-07-04 22:59 ` Pavel Machek
[not found] ` <alpine.LFD.0.98.0707041610530.9434@woody.linux-foundation.org>
2007-07-04 23:20 ` Pavel Machek
2007-07-03 7:12 ` Bernhard Walle
2007-07-04 19:37 ` Pavel Machek
2007-07-05 20:30 ` Bill Davidsen
[not found] <8CaWr-2o4-19@gated-at.bofh.it>
[not found] ` <8Cfjl-PJ-33@gated-at.bofh.it>
[not found] ` <8CfW1-1TX-23@gated-at.bofh.it>
[not found] ` <8ChEo-4yy-1@gated-at.bofh.it>
2007-07-02 13:11 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707022108.43293.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox