Re: [PATCH 4/5] UML - Simplify helper stack handling

Andrew Morton
2007-06-26T20:36:59Z

On Thu, 14 Jun 2007 16:26:55 -0400
Jeff Dike <jdike@addtoit.com> wrote:

> --- linux-2.6.21-mm.orig/arch/um/drivers/xterm.c 2007-06-13 17:13:42.000000000 -0400
> +++ linux-2.6.21-mm/arch/um/drivers/xterm.c 2007-06-13 18:44:41.000000000 -0400
> @@ -132,7 +132,7 @@ static int xterm_open(int input, int out
> }
>
> sprintf(title, data->title, data->device);
> - pid = run_helper(NULL, NULL, argv, NULL);
> + pid = run_helper(NULL, NULL, argv);
> if (pid < 0) {
> err = pid;
> printk(UM_KERN_ERR "xterm_open : run_helper failed, "

Something's gone wrong here. My copy of this file has

pid = run_helper(NULL, NULL, argv, &stack);