Re: Makefiles for GNU make (Re: [PATCH] LinuxPPS (with new syscalls API) - new version)

Rodolfo Giometti
2007-07-09T10:56:53Z

On Mon, Jul 09, 2007 at 12:56:11PM +0200, Oleg Verych wrote:
> On Mon, Jul 09, 2007 at 11:16:43AM +0200, Rodolfo Giometti wrote:
> > On Sun, Jul 08, 2007 at 11:05:32AM +0200, Oleg Verych wrote:
> > > * Rodolfo Giometti (Thu, 28 Jun 2007 18:14:50 +0200)
> > > * Organization: GNU/Linux Device Drivers, Embedded Systems and Courses
> > >
> > > > +.PHONY : all depend dep
> > > > +
> > > > +all : .depend $(TARGETS)
> > > > +
> > > > +.depend depend dep :
> > > > + $(CC) $(CFLAGS) -M $(TARGETS:=.c) > .depend
> > > []
> > > > +# -- Clean section ------------------------------------------------------------
> > > > +
> > > > +.PHONY : clean
> > > > +
> > > > +clean :
> > > > + rm -f *.o *~ core .depend
> > >
> > > Please see how currently .PHONY targets are used correctly, e.g. in
> > > linux/Makefile.
> >
> > I don't understand why you wish I use linux PHONY targets management
>
> Sorry i was not clear. Problem is `GNU make'[0], not management.
>
> [0] <http://article.gmane.org/gmane.comp.gnu.make.bugs/2481>
>
> > in a documentation Makefile... I suppose you are talking about
> > linux/Documentation/pps/Makefile which is just an example about people
> > may compile some testing/debugging programs. :-o
>
> So, after this example you may write correct Makefiles for `GNU make'.

I see... but I'm still a bit confused... if I well understand I should
change the Makefile as follow:

diff --git a/Documentation/pps/Makefile b/Documentation/pps/Makefile
index a2660a2..d766447 100644
--- a/Documentation/pps/Makefile
+++ b/Documentation/pps/Makefile
@@ -6,7 +6,7 @@ CFLAGS += -ggdb

# -- Actions section ----------------------------------------------------------
-.PHONY : all depend dep
+.PHONY : depend dep

all : .depend $(TARGETS)

@@ -20,8 +20,6 @@ endif

# -- Clean section ------------------------------------------------------------
-.PHONY : clean
-
clean :
rm -f *.o *~ core .depend
rm -f ${TARGETS}

Is that right?

Thanks,

Rodolfo