From: Rob Landley <rob@landley.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk
Subject: Don't miss the ARM-scsi fix.
Date: Tue, 3 Jul 2007 15:03:56 -0400 [thread overview]
Message-ID: <200707031503.56561.rob@landley.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
Just making sure this fix winds up in 2.6.23:
http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=4454/1
It fixes a regression that occurred between 2.6.20 and 2.6.20-rc1. Without
it, qemu-system-arm can't use emulated SCSI drives. It wasn't in -rc7, and
the attached patch Works For Me (tm).
Signed-off-by: Rob Landley <rob@landley.net>
Rob
--
"One of my most productive days was throwing away 1000 lines of code."
- Ken Thompson.
[-- Attachment #2: linux-armfix.patch --]
[-- Type: text/x-diff, Size: 1131 bytes --]
ARM Versatile PCI config reads of one byte width have the lowest two<br />
bits of the address cleared and result in reading from a wrong place<br />
in the config space. This change is to use word size accesses like it is done for halfword reads.
Byte reads are used for retrieving the IRQ number of a PCI device and the problem was not exposed until 2.6.20 because the value read was discarded in drivers/pci/setup-irq.c (recently fixed).
Signed-off-by: Andrzej Zaborowski <(address hidden)><br />
Acked-by: Paul Brook <(address hidden)>
Note 2 submitted by Russell King on 02 Jul 2007 12:39:41 (UTC)
Moved to applied
Applied to git-curr.
diff --git a/arch/arm/mach-versatile/pci.c b/arch/arm/mach-versatile/pci.c
index ba58223..ca82901 100644
--- a/arch/arm/mach-versatile/pci.c
+++ b/arch/arm/mach-versatile/pci.c
@@ -117,7 +117,10 @@ static int versatile_read_config(struct pci_bus *bus, unsigned int devfn, int wh
} else {
switch (size) {
case 1:
- v = __raw_readb(addr);
+ v = __raw_readl(addr);
+ if (where & 2) v >>= 16;
+ if (where & 1) v >>= 8;
+ v &= 0xff;
break;
case 2:
next reply other threads:[~2007-07-03 19:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-03 19:03 Rob Landley [this message]
2007-07-03 19:21 ` Don't miss the ARM-scsi fix Andrew Morton
2007-07-03 19:31 ` Russell King - ARM Linux
2007-07-04 1:17 ` Rob Landley
2007-07-04 12:00 ` andrzej zaborowski
2007-07-04 17:12 ` Russell King - ARM Linux
2007-07-03 21:45 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707031503.56561.rob@landley.net \
--to=rob@landley.net \
--cc=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox