* [PATCH] Two trivial whitespace fixes in lockdep/spinlock code
@ 2007-07-04 0:14 Jiri Kosina
2007-07-04 0:16 ` Andrew Morton
2007-07-04 8:29 ` Ingo Molnar
0 siblings, 2 replies; 5+ messages in thread
From: Jiri Kosina @ 2007-07-04 0:14 UTC (permalink / raw)
To: Andrew Morton; +Cc: Ingo Molnar, linux-kernel
From: Jiri Kosina <jkosina@suse.cz>
Two trivial whitespace fixes in lockdep/spinlock code
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index 1a5ff22..12ca5fd 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -1222,7 +1222,7 @@ register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force)
/*
* Debug-check: all keys must be persistent!
- */
+ */
if (!static_obj(lock->key)) {
debug_locks_off();
printk("INFO: trying to register non-static key.\n");
diff --git a/kernel/spinlock.c b/kernel/spinlock.c
index 2c6c2bf..5386d7e 100644
--- a/kernel/spinlock.c
+++ b/kernel/spinlock.c
@@ -28,7 +28,7 @@ int __lockfunc _spin_trylock(spinlock_t *lock)
spin_acquire(&lock->dep_map, 0, 1, _RET_IP_);
return 1;
}
-
+
preempt_enable();
return 0;
}
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Two trivial whitespace fixes in lockdep/spinlock code
2007-07-04 0:14 [PATCH] Two trivial whitespace fixes in lockdep/spinlock code Jiri Kosina
@ 2007-07-04 0:16 ` Andrew Morton
2007-07-09 17:45 ` Daniel Walker
2007-07-04 8:29 ` Ingo Molnar
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2007-07-04 0:16 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Ingo Molnar, linux-kernel
On Wed, 4 Jul 2007 02:14:42 +0200 (CEST) Jiri Kosina <jkosina@suse.cz> wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> Two trivial whitespace fixes in lockdep/spinlock code
>
> Cc: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>
> diff --git a/kernel/lockdep.c b/kernel/lockdep.c
> index 1a5ff22..12ca5fd 100644
> --- a/kernel/lockdep.c
> +++ b/kernel/lockdep.c
> @@ -1222,7 +1222,7 @@ register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force)
>
> /*
> * Debug-check: all keys must be persistent!
> - */
> + */
> if (!static_obj(lock->key)) {
> debug_locks_off();
> printk("INFO: trying to register non-static key.\n");
> diff --git a/kernel/spinlock.c b/kernel/spinlock.c
> index 2c6c2bf..5386d7e 100644
> --- a/kernel/spinlock.c
> +++ b/kernel/spinlock.c
> @@ -28,7 +28,7 @@ int __lockfunc _spin_trylock(spinlock_t *lock)
> spin_acquire(&lock->dep_map, 0, 1, _RET_IP_);
> return 1;
> }
> -
> +
> preempt_enable();
> return 0;
> }
Too trivial, sorry: we could generate 8 million patches like this.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Two trivial whitespace fixes in lockdep/spinlock code
2007-07-04 0:16 ` Andrew Morton
@ 2007-07-09 17:45 ` Daniel Walker
2007-07-09 18:14 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Walker @ 2007-07-09 17:45 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jiri Kosina, Ingo Molnar, linux-kernel
On Tue, 2007-07-03 at 17:16 -0700, Andrew Morton wrote:
> On Wed, 4 Jul 2007 02:14:42 +0200 (CEST) Jiri Kosina <jkosina@suse.cz> wrote:
>
> > From: Jiri Kosina <jkosina@suse.cz>
> >
> > Two trivial whitespace fixes in lockdep/spinlock code
> >
> > Cc: Ingo Molnar <mingo@elte.hu>
> > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> >
> > diff --git a/kernel/lockdep.c b/kernel/lockdep.c
> > index 1a5ff22..12ca5fd 100644
> > --- a/kernel/lockdep.c
> > +++ b/kernel/lockdep.c
> > @@ -1222,7 +1222,7 @@ register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force)
> >
> > /*
> > * Debug-check: all keys must be persistent!
> > - */
> > + */
> > if (!static_obj(lock->key)) {
> > debug_locks_off();
> > printk("INFO: trying to register non-static key.\n");
> > diff --git a/kernel/spinlock.c b/kernel/spinlock.c
> > index 2c6c2bf..5386d7e 100644
> > --- a/kernel/spinlock.c
> > +++ b/kernel/spinlock.c
> > @@ -28,7 +28,7 @@ int __lockfunc _spin_trylock(spinlock_t *lock)
> > spin_acquire(&lock->dep_map, 0, 1, _RET_IP_);
> > return 1;
> > }
> > -
> > +
> > preempt_enable();
> > return 0;
> > }
>
> Too trivial, sorry: we could generate 8 million patches like this.
Would you rather have one big patch that fixes a lot of this type of
stuff, or not have these types of patches at all ?
Daniel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Two trivial whitespace fixes in lockdep/spinlock code
2007-07-09 17:45 ` Daniel Walker
@ 2007-07-09 18:14 ` Andrew Morton
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Morton @ 2007-07-09 18:14 UTC (permalink / raw)
To: Daniel Walker; +Cc: Jiri Kosina, Ingo Molnar, linux-kernel
On Mon, 09 Jul 2007 10:45:46 -0700
Daniel Walker <dwalker@mvista.com> wrote:
> > Too trivial, sorry: we could generate 8 million patches like this.
>
> Would you rather have one big patch that fixes a lot of this type of
> stuff, or not have these types of patches at all ?
I guess one-patch-per-subsystem-maintainer would be best.
Sent To: that maintainer, Cc:'d to me, ideally. Some will resist.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Two trivial whitespace fixes in lockdep/spinlock code
2007-07-04 0:14 [PATCH] Two trivial whitespace fixes in lockdep/spinlock code Jiri Kosina
2007-07-04 0:16 ` Andrew Morton
@ 2007-07-04 8:29 ` Ingo Molnar
1 sibling, 0 replies; 5+ messages in thread
From: Ingo Molnar @ 2007-07-04 8:29 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Andrew Morton, linux-kernel
* Jiri Kosina <jkosina@suse.cz> wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> Two trivial whitespace fixes in lockdep/spinlock code
>
> Cc: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
thanks.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-07-09 18:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-04 0:14 [PATCH] Two trivial whitespace fixes in lockdep/spinlock code Jiri Kosina
2007-07-04 0:16 ` Andrew Morton
2007-07-09 17:45 ` Daniel Walker
2007-07-09 18:14 ` Andrew Morton
2007-07-04 8:29 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox