From: Adrian Bunk <bunk@stusta.de>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel@vger.kernel.org
Subject: [2.6 patch] remove mm/backing-dev.c:congestion_wait_interruptible()
Date: Wed, 4 Jul 2007 03:05:10 +0200 [thread overview]
Message-ID: <20070704010509.GG3492@stusta.de> (raw)
In-Reply-To: <1183502136.6494.74.camel@heimdal.trondhjem.org>
On Tue, Jul 03, 2007 at 06:35:36PM -0400, Trond Myklebust wrote:
> On Tue, 2007-07-03 at 14:48 -0700, Andrew Morton wrote:
> > On Sun, 1 Jul 2007 22:20:51 +0200
> > Adrian Bunk <bunk@stusta.de> wrote:
> >
> > > congestion_wait_interruptible() is no longer used.
> >
> > We might as well just delete it?
>
> I agree. We're better off deleting it, but either would be fine by me.
Updated patch below.
> Trond
cu
Adrian
<-- snip -->
congestion_wait_interruptible() is no longer used.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Trond Myklebust <trond.myklebust@fys.uio.no>
---
include/linux/backing-dev.h | 1 -
mm/backing-dev.c | 16 ----------------
2 files changed, 17 deletions(-)
--- linux-2.6.22-rc4-mm2/include/linux/backing-dev.h.old 2007-06-12 01:21:52.000000000 +0200
+++ linux-2.6.22-rc4-mm2/include/linux/backing-dev.h 2007-06-12 01:22:00.000000000 +0200
@@ -93,7 +93,6 @@
void clear_bdi_congested(struct backing_dev_info *bdi, int rw);
void set_bdi_congested(struct backing_dev_info *bdi, int rw);
long congestion_wait(int rw, long timeout);
-long congestion_wait_interruptible(int rw, long timeout);
void congestion_end(int rw);
#define bdi_cap_writeback_dirty(bdi) \
--- linux-2.6.22-rc6-mm1/mm/backing-dev.c.old 2007-07-04 00:44:10.000000000 +0200
+++ linux-2.6.22-rc6-mm1/mm/backing-dev.c 2007-07-04 00:44:24.000000000 +0200
@@ -55,22 +55,6 @@
}
EXPORT_SYMBOL(congestion_wait);
-long congestion_wait_interruptible(int rw, long timeout)
-{
- long ret;
- DEFINE_WAIT(wait);
- wait_queue_head_t *wqh = &congestion_wqh[rw];
-
- prepare_to_wait(wqh, &wait, TASK_INTERRUPTIBLE);
- if (signal_pending(current))
- ret = -ERESTARTSYS;
- else
- ret = io_schedule_timeout(timeout);
- finish_wait(wqh, &wait);
- return ret;
-}
-EXPORT_SYMBOL(congestion_wait_interruptible);
-
/**
* congestion_end - wake up sleepers on a congested backing_dev_info
* @rw: READ or WRITE
prev parent reply other threads:[~2007-07-04 1:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 20:20 [-mm patch] #if 0 mm/backing-dev.c:congestion_wait_interruptible() Adrian Bunk
2007-07-03 21:48 ` Andrew Morton
2007-07-03 22:35 ` Trond Myklebust
2007-07-04 1:05 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070704010509.GG3492@stusta.de \
--to=bunk@stusta.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox