Re: [PATCH] Re: [NETPOLL] netconsole: fix soft lockup when removing module

Jarek Poplawski
2007-07-04T06:33:44Z

On Mon, Jul 02, 2007 at 09:52:26AM +0200, Jarek Poplawski wrote:
>
> From my recent patch:
>
> > > #1
> > > Until kernel ver. 2.6.21 (including) cancel_rearming_delayed_work()
> > > required a work function should always (unconditionally) rearm with
> > > delay > 0 - otherwise it would endlessly loop. This patch replaces
> > > this function with cancel_delayed_work(). Later kernel versions don't
> > > require this, so here it's only for uniformity.
>
> But Oleg Nesterov <oleg@tv-sign.ru> found:
>
> > But 2.6.22 doesn't need this change, why it was merged?
> >
> > In fact, I suspect this change adds a race,
> ...
>
> His description was right (thanks), so this patch reverts #1.
>
> Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>

Oleg,

I think maybe you could ack these 2 netconsole patches...
They were done on your request but it looks like Andrew
is waiting on something...

Thanks,
Jarek P.