Re: [NETPOLL] netconsole: fix soft lockup when removing module

Oleg Nesterov
2007-07-02T09:23:59Z

On 07/02, Jarek Poplawski wrote:
>
> > > --- a/net/core/netpoll.c
> > > +++ b/net/core/netpoll.c
> > > @@ -72,7 +72,8 @@ static void queue_process(struct work_struct *work)
> > > netif_tx_unlock(dev);
> > > local_irq_restore(flags);
> > >
> > > - schedule_delayed_work(&npinfo->tx_work, HZ/10);
> > > + if (atomic_read(&npinfo->refcnt))
> > > + schedule_delayed_work(&npinfo->tx_work, HZ/10);
> > > return;
> > > }
>
> [...snip...]
>
> So, 2.6.21 needs something better (maybe you've found it btw.?),
> but they weren't too interested, anyway.

We can do a double flush trick. If queue_process() checks ->refcnt before
schedule_delayed_work() like above, netpoll_cleanup() can do

flush_scheduled_work();

// the next invocation of queue_process()
// must see ->refcnt == 0
if (!cancel_delayed_work(&npinfo->tx_work)) {
/* may be queued, wait for completion */
flush_scheduled_work();
}

Jarek, I don't understand net/, a silly question. Why do we need the #2 chunk?
Isn't it better to move skb_queue_purge(&npinfo->txq) after cancel_..._work()
instead?

Oleg.