From: Roman Zippel <zippel@linux-m68k.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Dave Jones <davej@redhat.com>, Andrew Morton <akpm@osdl.org>,
john stultz <johnstul@us.ibm.com>, Ingo Molnar <mingo@elte.hu>,
Stable Team <stable@kernel.org>,
"Fortier,Vincent [Montreal]" <Vincent.Fortier1@ec.gc.ca>
Subject: Re: [PATCH] NTP: remove clock_was_set() call to prevent deadlock
Date: Wed, 4 Jul 2007 13:06:59 +0200 [thread overview]
Message-ID: <200707041307.01116.zippel@linux-m68k.org> (raw)
In-Reply-To: <1183485920.3291.28.camel@chaos>
Hi,
On Tuesday 03 July 2007, Thomas Gleixner wrote:
> The clock_was_set() call in seconds_overflow() which happens only when
> leap seconds are inserted / deleted is wrong in two aspects:
>
> 1. it results in a call to on_each_cpu() with interrupts disabled
> 2. it is potential deadlock source vs. call_lock in smp_call_function()
>
> The only possible side effect of the removal might be, that an absolute
> CLOCK_REALTIME timer fires 1 second too late, in the rare case of leap
> second deletion and an absolute CLOCK_REALTIME timer which expires in
> the affected time frame. It will never fire too early.
That's a bit of an easy solution and doesn't fix the real problem. The
clock_was_set() calls were correct, what's broken is the locking. Why wasn't
that fixed instead?
I would at least like to see a comment there, why these calls were removed.
bye, Roman
next prev parent reply other threads:[~2007-07-04 11:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-03 18:05 [PATCH] NTP: remove clock_was_set() call to prevent deadlock Thomas Gleixner
2007-07-03 19:41 ` Ingo Molnar
2007-07-03 19:56 ` Thomas Gleixner
2007-07-04 11:06 ` Roman Zippel [this message]
2007-07-04 11:15 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707041307.01116.zippel@linux-m68k.org \
--to=zippel@linux-m68k.org \
--cc=Vincent.Fortier1@ec.gc.ca \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox