From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: Don't miss the ARM-scsi fix.
Date: Wed, 4 Jul 2007 18:12:38 +0100 [thread overview]
Message-ID: <20070704171237.GC14170@flint.arm.linux.org.uk> (raw)
In-Reply-To: <fb249edb0707040500o42e945afr9040cbd268942555@mail.gmail.com>
On Wed, Jul 04, 2007 at 02:00:58PM +0200, andrzej zaborowski wrote:
> It's just the case of being consistent with the already broken style
> in a function vs. correct style and inconsistency. I can never decide.
That's always a hard one to call, and the answer is generally to
follow the existing style, even if it's broken. At a later date,
a patch which _just_ fixes the style can be submitted.
The point of _just_ fixing the style is that it's trivial to prove
that no other changes have happened - you build the file without
the change and save a copy of the object. Apply the change and
rebuild, and compare the resulting text/data. They should be the
same, if not there's a bug somewhere.
(There have been instances where reformatting the code has introduced
subtle unexpected changes, so it's always worth performing that check
just in case.)
next prev parent reply other threads:[~2007-07-04 17:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-03 19:03 Don't miss the ARM-scsi fix Rob Landley
2007-07-03 19:21 ` Andrew Morton
2007-07-03 19:31 ` Russell King - ARM Linux
2007-07-04 1:17 ` Rob Landley
2007-07-04 12:00 ` andrzej zaborowski
2007-07-04 17:12 ` Russell King - ARM Linux [this message]
2007-07-03 21:45 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070704171237.GC14170@flint.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=balrogg@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox