Re: [RFC] get rid of CONFIG_DISABLE_CONSOLE_SUSPEND

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > > > diff --git a/drivers/char/lp.c b/drivers/char/lp.c
> > > > index 62051f8..8267ff8 100644
> > > > --- a/drivers/char/lp.c
> > > > +++ b/drivers/char/lp.c
> > > > @@ -144,7 +144,7 @@ static unsigned int lp_count = 0;
> > > >  static struct class *lp_class;
> > > >  
> > > >  #ifdef CONFIG_LP_CONSOLE
> > > > -static struct parport *console_registered; // initially NULL
> > > > +static struct parport *console_registered;
> > > >  #endif /* CONFIG_LP_CONSOLE */
> > > 
> > > Could you please avoid fixing things like this, white space etc. in this patch?
> > > It would be easier to read ...
> > 
> > Yep, sorry, it should be separate patch. I hope the idea is still
> > simple enough.
> 
> Yes, but I'm not sure if netconsole is the only one that we will want to have

Well, netconsole is the only one we know of.

> disabled.  Moreover, what if someone wants to use the netconsole regardless
> of the fact that it can crash the box?

He'll have to edit the sources at that point. I'd prefer not to have
too many "please crash the box" options.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html