From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758115AbXGEBVo (ORCPT ); Wed, 4 Jul 2007 21:21:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755438AbXGEBVj (ORCPT ); Wed, 4 Jul 2007 21:21:39 -0400 Received: from mailout.stusta.mhn.de ([141.84.69.5]:50936 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754742AbXGEBVj (ORCPT ); Wed, 4 Jul 2007 21:21:39 -0400 Date: Thu, 5 Jul 2007 03:22:06 +0200 From: Adrian Bunk To: Pavel Machek Cc: Paul Mackerras , "Rafael J. Wysocki" , Benjamin Herrenschmidt , Matthew Garrett , linux-kernel@vger.kernel.org, linux-pm@lists.linux-foundation.org Subject: Re: The big suspend mess Message-ID: <20070705012206.GN3492@stusta.de> References: <20070703042916.GA17240@srcf.ucam.org> <200707031456.40890.rjw@sisk.pl> <1183497290.3388.4.camel@localhost.localdomain> <200707032332.49694.rjw@sisk.pl> <18059.5165.861038.392332@cargo.ozlabs.ibm.com> <20070704221952.GM3492@stusta.de> <20070705002747.GA2952@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20070705002747.GA2952@elf.ucw.cz> User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 05, 2007 at 02:27:47AM +0200, Pavel Machek wrote: > > > IMHO the suspend code is currently way too much of a moving target which > > results in this mess. > > > > The correct order seems to be: > > 0. Get someone to sign up as a maintainer for suspend, so we have > someone to blame for the mess? :-) The "SOFTWARE SUSPEND" entry in MAINTAINERS already contains a victim... ;-) My impression is that suspend is an area of the kernel that does not lack maintainers - you and Rafael are doing a good job, and there's e.g. also the maintained code formerly known as suspend2. But some basic questions like e.g. - What should be done in the kernel and what in userspace? - How should this be implemented? - What must subsystems and drivers do? - What must subsystems and drivers not do? seem to be in a constant flux because the big picture everyone agrees upon seems to be missing. > > 1. agree on what the suspend code as a whole should look like > > 2. implement this > > 3. fix ALL drivers to work at least as good as they do today > > 4. get it tested in -mm > > 5. fix all bugs people run into > > 6. submit it for inclusion in Linus' tree > > 7. quickly work on the most likely big amount of bug reports > > > > Step 1 is the most important one - evolving code is often something > > good, but in this case with different people trying to evolve the > > suspend code in different directions it simply results in a big mess. > > Pavel cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed