Re: [PATCH] dio: remove bogus refcounting BUG_ON

Badari Pulavarty
2007-07-05T17:17:35Z

On Thu, 2007-07-05 at 10:11 -0700, Zach Brown wrote:
> > the BUG_ON(). But unfortunately, our perf. team is able reproduce the
> > problem.
>
> What are they doing to reproduce it? How much setup does it take?

Huge OLTP run :(

>
> > Debug indicated that, the ret2 == 1 :(
>
> That could be consistent with the theory that we're racing with the
> dio struct being freed and reused before it's tested in the BUG_ON()
> condition. Suparna's suggestion to sample dio->is_async before
> releasing the refcount and using that in the BUG_ON condition is a
> good one.

I will ask them to try that.

Thanks,
Badari