From: Oleg Nesterov <oleg@tv-sign.ru>
To: Ingo Molnar <mingo@elte.hu>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 1/2] workqueue: debug flushing deadlocks with lockdep
Date: Thu, 5 Jul 2007 18:52:43 +0400 [thread overview]
Message-ID: <20070705145243.GA189@tv-sign.ru> (raw)
In-Reply-To: <20070705144047.GA9548@elte.hu>
On 07/05, Ingo Molnar wrote:
>
> * Oleg Nesterov <oleg@tv-sign.ru> wrote:
>
> > OTOH. Perhaps we can can forbid such a behaviour? Andrew, do you know
> > any good example of "keventd trying to flush its own queue" ?
>
> i'd prefer to make the API a little bit stricter: such recursion is
> nasty. Btw., what mechanism prevents the second instance of
> run_workqueue() calling into a work->func() again?
Nothing. work->func() can re-schedule itself and then call flush_workqueue().
We have a "morton gets to eat his hat" check in run_workqueue() though.
So I agree with you, such recursion is indeed bad. Can we forbid this?
In that case this patch is even more perfect :)
Oleg.
next prev parent reply other threads:[~2007-07-05 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 11:07 [PATCH 0/2] workqueue lockup debugging Johannes Berg
2007-07-05 11:07 ` [PATCH 1/2] workqueue: debug flushing deadlocks with lockdep Johannes Berg
2007-07-05 14:32 ` Oleg Nesterov
2007-07-05 14:40 ` Ingo Molnar
2007-07-05 14:52 ` Oleg Nesterov [this message]
2007-07-06 10:42 ` Johannes Berg
2007-07-05 11:07 ` [PATCH 2/2] workqueue: debug work related " Johannes Berg
2007-07-05 15:36 ` Oleg Nesterov
2007-07-06 10:43 ` Johannes Berg
2007-07-06 12:53 ` Oleg Nesterov
2007-07-11 11:37 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070705145243.GA189@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox