From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Pavel Machek <pavel@ucw.cz>
Cc: Nigel Cunningham <nigel@nigel.suspend2.net>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] Optional Beeping During Resume From Suspend To Ram.
Date: Thu, 5 Jul 2007 21:03:16 +0200 [thread overview]
Message-ID: <200707052103.17104.rjw@sisk.pl> (raw)
In-Reply-To: <20070704224653.GB2491@elf.ucw.cz>
On Thursday, 5 July 2007 00:46, Pavel Machek wrote:
> Hi!
>
> > > Here's the version that uses just one variable, relative to Nigel's
> > > patch. Hmm, and it also closes nasty trap for the user in
> > > acpi_sleep_setup; order of parameters actually mattered there,
> > > acpi_sleep=s3_bios,s3_mode doing something different from
> > > acpi_sleep=s3_mode,s3_bios . It actually works here.
> > >
> > > Will you fold it into patch28, or should I create a changelog?
> >
> > Hmm, I think we should keep the record straight. Please add a changelog
> > if that's not a problem.
>
> (I also added documentation and removed the superfluous beep_flags).
OK, thanks.
Added to the patchset as
http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.22-rc7/patches/50-Optional-Beeping-During-Resume-From-Suspend-To-Ram-tidy.patch
I think both patches are -mm-ready, aren't they?
Greetings,
Rafael
--
"Premature optimization is the root of all evil." - Donald Knuth
next prev parent reply other threads:[~2007-07-05 18:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 11:18 [PATCH] Optional Beeping During Resume From Suspend To Ram Nigel Cunningham
2007-06-19 21:33 ` Rafael J. Wysocki
2007-06-20 22:09 ` Rafael J. Wysocki
2007-06-20 22:24 ` Nigel Cunningham
2007-06-21 21:20 ` Rafael J. Wysocki
2007-06-28 14:25 ` Pavel Machek
2007-06-28 22:27 ` Nigel Cunningham
2007-06-29 18:03 ` Stefan Seyfried
2007-06-29 22:35 ` Pavel Machek
2007-06-30 10:15 ` Rafael J. Wysocki
2007-06-30 10:11 ` Pavel Machek
2007-06-30 20:30 ` Rafael J. Wysocki
2007-07-04 21:29 ` Pavel Machek
2007-07-04 21:50 ` Rafael J. Wysocki
2007-07-04 22:46 ` Pavel Machek
2007-07-05 19:03 ` Rafael J. Wysocki [this message]
2007-07-05 22:32 ` Pavel Machek
2007-07-04 22:34 ` Nigel Cunningham
2007-07-04 22:48 ` Pavel Machek
2007-07-04 22:56 ` Nigel Cunningham
2007-07-04 23:01 ` Pavel Machek
2007-07-04 23:10 ` Nigel Cunningham
2007-07-04 23:25 ` Pavel Machek
2007-07-05 18:43 ` Rafael J. Wysocki
2007-07-05 22:37 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707052103.17104.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nigel@nigel.suspend2.net \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox