From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759258AbXGELiR (ORCPT ); Thu, 5 Jul 2007 07:38:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755266AbXGELiH (ORCPT ); Thu, 5 Jul 2007 07:38:07 -0400 Received: from nigel.suspend2.net ([203.171.70.205]:48532 "EHLO nigel.suspend2.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754671AbXGELiF (ORCPT ); Thu, 5 Jul 2007 07:38:05 -0400 From: Nigel Cunningham Reply-To: nigel@suspend2.net To: "Rafael J. Wysocki" Subject: Re: [RFC][PATCH -mm] PM: Do not sync from within the freezer during suspend to RAM Date: Thu, 5 Jul 2007 21:37:57 +1000 User-Agent: KMail/1.9.6 Cc: nigel@suspend2.net, Pavel Machek , pm list , Benjamin Herrenschmidt , LKML , Matthew Garrett , Oliver Neukum , Paul Mackerras , Miklos Szeredi , Ingo Molnar References: <200707041658.59588.rjw@sisk.pl> <200707050852.15392.nigel@nigel.suspend2.net> <200707051328.50845.rjw@sisk.pl> In-Reply-To: <200707051328.50845.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2170237.7EuUvR8Xdo"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200707052137.58164.nigel@nigel.suspend2.net> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org --nextPart2170237.7EuUvR8Xdo Content-Type: text/plain; charset="cp 850" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi. On Thursday 05 July 2007 21:28:49 Rafael J. Wysocki wrote: > On Thursday, 5 July 2007 00:52, Nigel Cunningham wrote: > > On Thursday 05 July 2007 08:49:42 Pavel Machek wrote: > > > On Thu 2007-07-05 08:48:15, Nigel Cunningham wrote: > > > > On Thursday 05 July 2007 00:58:58 Rafael J. Wysocki wrote: > > > > > The syncing of filesystems from within the freezer in not needed = for=20 > > suspend=20 > > > > to > > > > > RAM. Change freeze_processes() so that it doesn't execute=20 sys_sync()=20 > > and > > > > > introduce the "syncing" version of it to be called from the=20 hibernation=20 > > code > > > > > paths. > > > > >=20 > > > > > Signed-off-by: Rafael J. Wysocki > > > > > --- > > > > > include/linux/freezer.h | 14 ++++++++++++-- > > > > > kernel/power/disk.c | 2 +- > > > > > kernel/power/main.c | 6 ++++++ > > > > > kernel/power/process.c | 8 +++++--- > > > > > kernel/power/user.c | 2 +- > > > > > 5 files changed, 25 insertions(+), 7 deletions(-) > > > >=20 > > > > Looks ok, except that I wonder if you want the following fragment. = It=20 > > looks to=20 > > > > me (looking at rc6) like with this code, you'll currently call=20 sys_sync=20 > > twice=20 > > > > when suspending to ram. Maybe I'm misreading it. Also, shouldn't it= be=20 > > done=20 > > > > after taking the mutex? > > >=20 > > > sys_sync() should be okay to call, mutex or not. > >=20 > > Yeah. That wasn't my point, sorry. Calling sys_sync is pointless if you= 're=20 > > going to fail to take the mutex. It makes more sense to know you've got= it=20 > > before you start doing things related to actually suspending. >=20 > Well, that's a valid point, I'll move it under the mutex. Okee doke. =20 > And why do you think it will be called twice? Hmm. Looking again now, I can't see why I thought that. Maybe I just hadn't= =20 had enough caffeine today at that stage :) Nigel =2D-=20 See http://www.tuxonice.net for Howtos, FAQs, mailing lists, wiki and bugzilla info. --nextPart2170237.7EuUvR8Xdo Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBGjNgWN0y+n1M3mo0RAqisAJ4hzqS9GnL1xQXN/P4K6OltNmpvegCfdmsO IH4L8GvZC1SXQ8eeM85mIgg= =BFJ9 -----END PGP SIGNATURE----- --nextPart2170237.7EuUvR8Xdo--