From: Andres Salomon <dilinger@queued.net>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jordan Crouse <jordan.crouse@amd.com>,
info-linux@geode.amd.com, gregkh@suse.de,
linux-pci@atrey.karlin.mff.cuni.cz, tsylla@gmail.com
Subject: [PATCH] PCI: do not delay when changing power states on Geode
Date: Thu, 5 Jul 2007 22:13:51 -0400 [thread overview]
Message-ID: <20070705221351.97d14df0.dilinger@queued.net> (raw)
Geode hardware requires no delay when doing power transition for PCI;
the board doesn't even have a real PCI bus. Thanks to Tom Sylla for
pointing this out. We can save precious milliseconds when changing power
states to D3hot by getting rid of this delay.
We do this as a PCI quirk.
Signed-off-by: Andres Salomon <dilinger@debian.org>
---
drivers/pci/quirks.c | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 01d8f8a..b85fd5f 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -1368,6 +1368,20 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x260a, quirk_intel_pcie_pm);
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, 0x260b, quirk_intel_pcie_pm);
/*
+ * Geode hardware does not require any sort of delay when
+ * transitioning between PCI power states. This allows us to shave
+ * off time when doing suspend/resume.
+ */
+static void __init quirk_geode_pci_pm(struct pci_dev *dev)
+{
+ pci_pm_d3_delay = 0;
+}
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_CYRIX, PCI_DEVICE_ID_CYRIX_5530_LEGACY,
+ quirk_geode_pci_pm);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_CS5536_ISA,
+ quirk_geode_pci_pm);
+
+/*
* Toshiba TC86C001 IDE controller reports the standard 8-byte BAR0 size
* but the PIO transfers won't work if BAR0 falls at the odd 8 bytes.
* Re-allocate the region if needed...
next reply other threads:[~2007-07-06 2:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-06 2:13 Andres Salomon [this message]
2007-07-06 10:05 ` [PATCH] PCI: do not delay when changing power states on Geode Alan Cox
2007-07-08 15:44 ` UNS: " Andres Salomon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070705221351.97d14df0.dilinger@queued.net \
--to=dilinger@queued.net \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=info-linux@geode.amd.com \
--cc=jordan.crouse@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=tsylla@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox