Re: [PATCH] i386/x86_64: Insert HPET firmware resource after PCI enumeration has completed

Matthias Lenk
2007-07-09T14:08:16Z

Andi, Aaron,
I retested the patch with Andi's patch not reverted (that's the way it's
meant to be I guess) and then it works! I can now boot with HPET enabled.

Thanks,

Matthias

Matthias Lenk wrote:
> Aaron, I tested the patch on my affected system and unfortunately it
> did not work. The BAR1 resource still gets overridden and hence the
> same effects as before.
>
> Thanks,
>
> Matthias
>
> Andi Kleen wrote:
>> On Friday 06 July 2007 00:27:24 Aaron Durbin wrote:
>>
>>> Insert HPET resources after pci probing has been completed in order
>>> to avoid
>>> resource conflicts with PCI resource reservation. With this change the
>>> HPET firmware resources will be identified, but it should also not
>>> cause
>>> issues when the HPET address falls on a BAR in a PCI device, and the
>>> PCI
>>> enumeration cannot reserve the resources.
>>>
>>
>> But what advantage does it have when it's already reserved by PCI?
>>
>> That's only a cosmetic change, isn't it? A lot of code for cosmetics.
>>
>> -Andi
>>
>>
>>
>
>
>