Re: [PATCH] i386/x86_64: Insert HPET firmware resource after PCI enumeration has completed

Aaron Durbin
2007-07-06T12:45:37Z

On 7/6/07, Andi Kleen <ak@suse.de> wrote:
> On Friday 06 July 2007 00:27:24 Aaron Durbin wrote:
> >
> > Insert HPET resources after pci probing has been completed in order to avoid
> > resource conflicts with PCI resource reservation. With this change the
> > HPET firmware resources will be identified, but it should also not cause
> > issues when the HPET address falls on a BAR in a PCI device, and the PCI
> > enumeration cannot reserve the resources.
>
> But what advantage does it have when it's already reserved by PCI?
>
> That's only a cosmetic change, isn't it? A lot of code for cosmetics.
>

To my knowledge, not every machine has the HPET live on a BAR in PCI space. It
is cosmetic, but it shows what devices are using what memory address space in
/proc/iomem so one doesn't need to dig through dmesg to piece things together.

I am going to work w/ Matthias to see if we can get a patch working with his
system. I think that it is beneficial to easily view where resources are being
used, but I do understand the prudence.

-Aaron