From: Andrew Morton <akpm@linux-foundation.org>
To: James Morris <jmorris@namei.org>
Cc: Heikki Orsila <shdl@zakalwe.fi>,
Yoann Padioleau <padator@wanadoo.fr>,
kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] some kmalloc/memset ->kzalloc (tree wide)
Date: Fri, 6 Jul 2007 16:16:17 -0700 [thread overview]
Message-ID: <20070706161617.072f7eea.akpm@linux-foundation.org> (raw)
In-Reply-To: <Line.LNX.4.64.0707061806390.18415@d.namei>
On Fri, 6 Jul 2007 18:07:20 -0400 (EDT)
James Morris <jmorris@namei.org> wrote:
> On Fri, 6 Jul 2007, Heikki Orsila wrote:
>
> > > Transform some calls to kmalloc/memset to a single kzalloc (or
> > > kcalloc).
> >
> > I looked all the files through. They looked good to me, except
> > one case:
>
> I checked the drivers/net and net/ changes and they looked ok (aside from
> the above).
>
>
OK, thanks for checking it, guys.
Yoann, the "tree wide" thing really is a problem. Your patch here is
touching ten or more maintainers' code and it really does want to be split
into ten separate patches and fed into the tree via the appropriate routes.
I can take care of that routing if I have the ten patches, but this time I
really can't be bothered splitting the patch up (it's rather boring, and
gets error-prone).
For this patch, I tossed out the ten or so hunks which conflicted with
other pending patches in the various trees and I shall just grit the teeth
and maintain and merge it as a single whopping patch. (At least this way
I'll actually get some scsi stuff merged). Anything which conflicts with
anyone's outstanding work will be dropped.
For any future patches, _please_ split them up along some sane lines.
Generally you'll find that one patch per second-level directory works
pretty well: drivers/net, drivers/scsi, drivers/usb, fs/ext2, drivers/char,
etc.
Thanks.
next prev parent reply other threads:[~2007-07-06 23:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-06 16:51 [PATCH] some kmalloc/memset ->kzalloc (tree wide) Yoann Padioleau
2007-07-06 17:04 ` Peter Zijlstra
2007-07-06 17:54 ` Christoph Lameter
2007-07-06 17:55 ` Heikki Orsila
2007-07-06 22:07 ` James Morris
2007-07-06 23:16 ` Andrew Morton [this message]
2007-07-07 13:07 ` Tilman Schmidt
2007-07-07 13:36 ` yoann padioleau
2007-07-07 23:06 ` Tilman Schmidt
2007-07-07 18:42 ` Jan Engelhardt
2007-07-08 19:45 ` Luca Tettamanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070706161617.072f7eea.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jmorris@namei.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=padator@wanadoo.fr \
--cc=shdl@zakalwe.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox