Re: [patch 10/10] Scheduler profiling - Use immediate values

Andi Kleen
2007-07-04T21:46:18Z

Alexey Dobriyan <adobriyan@gmail.com> writes:

> On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote:
> > Use immediate values with lower d-cache hit in optimized version as a
> > condition for scheduler profiling call.
>
> I think it's better to put profile.c under CONFIG_PROFILING as
> _expected_, so CONFIG_PROFILING=n users won't get any overhead, immediate or
> not. That's what I'm going to do after test-booting bunch of kernels.

No, it's better to handle this efficiently at runtime e.g. for
distribution kernels. Mathieu's patch is good

-Andi