Re: [patch 10/10] Scheduler profiling - Use immediate values

Bodo Eggert
2007-07-05T15:24:18Z

Andi Kleen <andi@firstfloor.org> wrote:
> Alexey Dobriyan <adobriyan@gmail.com> writes:
>> On Tue, Jul 03, 2007 at 12:40:56PM -0400, Mathieu Desnoyers wrote:

>> > Use immediate values with lower d-cache hit in optimized version as a
>> > condition for scheduler profiling call.
>>
>> I think it's better to put profile.c under CONFIG_PROFILING as
>> _expected_, so CONFIG_PROFILING=n users won't get any overhead, immediate or
>> not. That's what I'm going to do after test-booting bunch of kernels.
>
> No, it's better to handle this efficiently at runtime e.g. for
> distribution kernels. Mathieu's patch is good

IMO you should combine them. For distibutions, it may be good to include
profiling support unconditionally, but how many of the vanilla kernel users
are going to use profiling at all?
--
A man inserted an advertisement in the classified: Wife Wanted."
The next day he received a hundred letters. They all said the
same thing: "You can have mine."
Friß, Spammer: oztx1@nAQd3C.7eggert.dyndns.org wGhu@InUYZ.7eggert.dyndns.org