From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754560AbXGGITn (ORCPT ); Sat, 7 Jul 2007 04:19:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751486AbXGGITb (ORCPT ); Sat, 7 Jul 2007 04:19:31 -0400 Received: from agminet01.oracle.com ([141.146.126.228]:23849 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751362AbXGGIT3 (ORCPT ); Sat, 7 Jul 2007 04:19:29 -0400 Date: Sat, 7 Jul 2007 01:18:53 -0700 From: Joel Becker To: Satyam Sharma Cc: Linux Kernel Mailing List , Keiichi Kii , Netdev , Matt Mackall , Andrew Morton , David Miller Subject: Re: [PATCH -mm 9/9] netconsole: Support dynamic reconfiguration using configfs Message-ID: <20070707081852.GC1011@tasint.org> Mail-Followup-To: Satyam Sharma , Linux Kernel Mailing List , Keiichi Kii , Netdev , Matt Mackall , Andrew Morton , David Miller References: <20070704110739.28520.5036.sendpatchset@cselinux1.cse.iitk.ac.in> <20070704110824.28520.11661.sendpatchset@cselinux1.cse.iitk.ac.in> <20070707060114.GB1011@tasint.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. User-Agent: Mutt/1.5.13 (2006-08-11) X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 07, 2007 at 01:18:45PM +0530, Satyam Sharma wrote: > However, for items that are statically initialized (often the > group->cg_item members of subsystems or default groups) we often simply > set ci_namebuf and then call config_item_init() -- say via > config_group_init(), like I've done with the netconsole subsystem in this > patch -- but config_item_init() does not set ci_name for such items to > ci_namebuf. This means the ci_name member of _initialized_ config_items > with their names in ci_namebuf is left un-initialized (NULL, actually, > because the subsys / default group would likely be static). Configfs notices subsystems and default groups and handles this. See configfs_register_subsystem() and create_default_group() in fs/configfs/dir.c > Right. We shouldn't special case (at least not without adding a comment > why that would be right) and we never know what might happen to the code > at some later day. So let's keep the get() / put() pair. If you're keeping them, don't do the "empty_item", check the name. Otherwise, the changes you describe sound good. Joel -- "I have never let my schooling interfere with my education." - Mark Twain Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127