From: Ingo Molnar <mingo@elte.hu>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
shaohua.li@intel.com
Subject: Re: [PATCH][RFC] kvm-scheduler integration
Date: Sun, 8 Jul 2007 15:59:05 +0200 [thread overview]
Message-ID: <20070708135905.GA24991@elte.hu> (raw)
In-Reply-To: <4690EC47.6060904@qumranet.com>
* Avi Kivity <avi@qumranet.com> wrote:
> >> Won't that increase task_struct (16 bytes on 64-bit) unnecessarily?
> >> The function pointers are common to all virtual machines.
> >
> > well, this function pointer could then be reused by other virtual
> > machines as well, couldnt it?
>
> I don't get this. If we add a couple of members to task_struct, it
> can't be reused. The values will be the same across all tasks, but
> the memory will be gone (including tasks which aren't virtual
> machines).
i mean, the function pointer is set by KVM, but it could be set to a
different value by other hypervisors.
but ... no strong feelings either way, your patch is certainly fine.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2007-07-08 13:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-08 12:58 [PATCH][RFC] kvm-scheduler integration Avi Kivity
2007-07-08 13:09 ` Ingo Molnar
2007-07-08 13:16 ` Avi Kivity
2007-07-08 13:36 ` Ingo Molnar
2007-07-08 13:35 ` Ingo Molnar
2007-07-08 13:41 ` Avi Kivity
2007-07-08 13:48 ` Ingo Molnar
2007-07-08 13:53 ` Avi Kivity
2007-07-08 13:59 ` Ingo Molnar [this message]
2007-07-08 15:13 ` Avi Kivity
2007-07-10 11:18 ` Avi Kivity
2007-07-10 11:30 ` Ingo Molnar
2007-07-08 23:32 ` [kvm-devel] " Rusty Russell
2007-07-09 6:39 ` Avi Kivity
2007-07-10 1:09 ` Rusty Russell
2007-07-10 5:53 ` Avi Kivity
2007-07-10 6:47 ` Rusty Russell
2007-07-10 7:19 ` Avi Kivity
2007-07-10 8:01 ` Rusty Russell
2007-07-10 8:24 ` Avi Kivity
2007-07-11 5:50 ` Avi Kivity
2007-07-08 19:07 ` Andi Kleen
2007-07-09 6:41 ` Avi Kivity
2007-07-09 8:50 ` Shaohua Li
2007-07-09 9:46 ` Avi Kivity
2007-07-09 10:21 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070708135905.GA24991@elte.hu \
--to=mingo@elte.hu \
--cc=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox