public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Ulrich Drepper <drepper@redhat.com>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer	dereference - git-bisect result
Date: Sun, 8 Jul 2007 18:34:16 +0100	[thread overview]
Message-ID: <20070708173416.GG21668@ftp.linux.org.uk> (raw)
In-Reply-To: <469119A3.6030409@redhat.com>

On Sun, Jul 08, 2007 at 10:06:43AM -0700, Ulrich Drepper wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Markus Trippelsdorf wrote:
> > I tested this further and it turned out that the Linus tree is also
> > affected. So I ran git-bisect, after I found out that version
> > 2.6.21.6 was not affected by this bug.
> 
> Try this patch.  The vfs_permission test can be skipped since the VFS
> isn't involved.  We got the inode etc from a file descriptor.
 
Like hell.  At the very least you want it to be opened for write.
And even that is dubious, since "process has write access to file"
is not quite the same thing as "somebody had given the process a
descriptor opened for write".

  parent reply	other threads:[~2007-07-08 17:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-08  5:14 2.6.22-rc6-mm1-cfs-v19 Unable to handle kernel NULL pointer dereference (reproducable) Markus Trippelsdorf
2007-07-08  8:20 ` Andrew Morton
2007-07-08 10:09   ` Markus Trippelsdorf
2007-07-08 15:28     ` 2.6.22-rc6(mm1) Unable to handle kernel NULL pointer dereference - git-bisect result Markus Trippelsdorf
2007-07-08 17:02       ` Linus Torvalds
2007-07-08 17:06       ` Ulrich Drepper
2007-07-08 17:33         ` Markus Trippelsdorf
2007-07-08 17:34         ` Al Viro [this message]
2007-07-08 17:41           ` Ulrich Drepper
2007-07-08 18:12             ` Linus Torvalds
2007-07-08 18:24               ` Ulrich Drepper
2007-07-08 18:31                 ` Al Viro
2007-07-08 18:40                 ` Linus Torvalds
2007-07-08 18:30               ` Linus Torvalds
2007-07-08 18:34                 ` Al Viro
2007-07-08 18:38                 ` Linus Torvalds
2007-07-08 18:51                   ` Al Viro
2007-07-08 19:00                     ` Linus Torvalds
2007-07-08 19:26                       ` Al Viro
2007-07-08 18:19             ` Al Viro
2007-07-09 12:40 ` 2.6.22-rc6-mm1-cfs-v19 Unable to handle kernel NULL pointer dereference (reproducable) Lenar Lõhmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070708173416.GG21668@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=drepper@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus@trippelsdorf.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox