public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org
Subject: [PATCH 2/4] Initialize filp->private_data only once in em28xx_v4l2_open
Date: Sun, 8 Jul 2007 18:03:44 +0200	[thread overview]
Message-ID: <200707081803.44377.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <200707081754.03824.eike-kernel@sf-tec.de>

Some lines later filp->private_data is initialized to dev again. Since there
are some checks that might fail in the mean time keep the later version.

Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>

---
commit 7103e0b114b01a16d7c1ea71914d5069d974167d
tree 6b976d7ce4e872b32805d7df73dd13b5349d439f
parent 39c068bce1d63f6c1345c1ddfda1841d9fd20c74
author Rolf Eike Beer <eike-kernel@sf-tec.de> Tue, 25 Jul 2006 17:55:34 +0200
committer Rolf Eike Beer <eike-kernel@sf-tec.de> Tue, 25 Jul 2006 17:55:34 +0200

 drivers/media/video/em28xx/em28xx-video.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/em28xx/em28xx-video.c b/drivers/media/video/em28xx/em28xx-video.c
index 2a461dd..b2ae0c8 100644
--- a/drivers/media/video/em28xx/em28xx-video.c
+++ b/drivers/media/video/em28xx/em28xx-video.c
@@ -268,8 +268,6 @@ static int em28xx_v4l2_open(struct inode *inode, struct file *filp)
 	if (NULL == dev)
 		return -ENODEV;
 
-	filp->private_data=dev;
-
 	em28xx_videodbg("open minor=%d type=%s users=%d\n",
 				minor,v4l2_type_names[dev->type],dev->users);
 

  parent reply	other threads:[~2007-07-09  7:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-08 15:53 [PATCH 0/4] misc patches Rolf Eike Beer
2007-07-08 15:56 ` [PATCH 1/4] Use kcalloc() in drivers/video/aty/atyfb_base.c Rolf Eike Beer
2007-07-08 16:03 ` Rolf Eike Beer [this message]
2007-07-08 16:07 ` [PATCH 3/4][Doc] Fix typos in fs/sysfs/file.c Rolf Eike Beer
2007-07-08 16:09 ` [PATCH 4/4][Doc] Document pci_iomap() Rolf Eike Beer
2007-07-09 15:58   ` Randy Dunlap
2007-07-10  9:11     ` [PATCH][Doc] " Rolf Eike Beer
2007-07-10 15:24       ` Randy Dunlap
2007-07-09 21:24 ` [PATCH 0/4] misc patches Randy Dunlap
2007-07-09 21:27   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200707081803.44377.eike-kernel@sf-tec.de \
    --to=eike-kernel@sf-tec.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox