Re: [PATCH] LinuxPPS (with new syscalls API) - new version

David Woodhouse
2007-06-29T16:23:40Z

On Fri, 2007-06-29 at 18:23 +0200, Rodolfo Giometti wrote:
> On Fri, Jun 29, 2007 at 04:41:33PM +0100, David Woodhouse wrote:
> >
> > <asm-i386/signal.h> includes <linux/time.h>, for some reason.
> > <asm-powerpc/signal.h> doesn't.
> >
> > You shouldn't rely on <linux/time.h> being pulled in like that -- you
> > either need a forward declaration of struct timespec, or to include
> > <linux/time.h> for yourself from <linux/pps.h>
>
> Can you please check if this patch resolve your problem?
>
> diff --git a/include/linux/pps.h b/include/linux/pps.h
> index 6b53864..fe8c645 100644
> --- a/include/linux/pps.h
> +++ b/include/linux/pps.h
> @@ -33,6 +33,7 @@
>
> #ifndef __KERNEL__
> #include <asm/types.h>
> +#include <linux/time.h>
> #include <sys/time.h>
> #endif

You'll need to put it in an #else case, not in #ifndef __KERNEL__.

--
dwmw2