Re: [PATCH] LinuxPPS (with new syscalls API) - new version

Rodolfo Giometti
2007-06-30T17:12:31Z

On Fri, Jun 29, 2007 at 05:40:52PM +0100, David Woodhouse wrote:
>
> Remember you have to support _both_ 32-bit and 64-bit system calls. You
> need to define struct compat_pps_info and struct compat_pps_params, and
> you'll have to provide a compat wrapper for sys_time_pps_getparams() and
> sys_time_pps_setparams(). You'll also need to extend your
> compat_sys_time_pps_fetch() wrapper to handle the struct pps_info too.

At this point I'm seriously considfering your previous suggestion:

Had you considered changing the API so that you don't need the
compatibility wrapper at all? Could you take an integer number of
µS or ms instead of a struct timespec?

Maybe I can define a special struct for exchanging time data as:

struct pps_timedata_s {
long sec;
long nsec;
}

and managing time data conversions at userland...

What do you think about that? :)

Thanks,

Rodolfo