Re: [PATCH] LinuxPPS (with new syscalls API) - new version

Rodolfo Giometti
2007-06-29T16:33:18Z

On Fri, Jun 29, 2007 at 04:55:47PM +0100, David Woodhouse wrote:

> You missed one. This should be -EFAULT too. And there's not a huge
> amount of point in keeping the access_ok() checks elsewhere, since
> copy_to_user() does that for itself.

Ok, fixed.

> Oh, and I think you do need compat magic for 'struct pps_info' and
> 'struct pps_params' too -- there's a struct timespec hidden deep in
> there, as well as 'unsigned long longpad[3]'.

Gulp! Can you please give me some advices in order to solve also this
problem? Should I use some "ifdef CONFIG_COMPAT" into those
structures? :-o

> Can you explain the 'union pps_timeu'? It seems very odd. How do we know
> which member of the union should be used?

This union is defined by the RFC 2783... we can know which member of
the union should be used by using define PPS_TSFMT_TSPEC for variable
tsformat into function time_pps_fetch().

Ciao,

Rodolfo