Re: [PATCH] LinuxPPS (with new syscalls API) - new version

David Woodhouse
2007-07-10T16:06:05Z

On Mon, 2007-07-09 at 15:19 +0200, Rodolfo Giometti wrote:
>
> > Also read Documentation/volatile-considered-harmful.txt and ponder
> > deeply your use of 'volatile' on certain members of struct pps_s.
>
> I read such document but I'm still convinced that the attribute
> volatile is needed for {assert,clear}_sequence and {assert,clear}_tu
> since inside pps_event() they are updated without any locks at all
> thanks to the dummy_info variable which is used for unallocated PPS
> sources.

I'm sure the version with 'volatile' will also be broken then. Sounds
like the right answer is to fix the locking.

--
dwmw2