Re: [PATCH] LinuxPPS (with new syscalls API)

David Woodhouse
2007-06-27T17:50:07Z

On Wed, 2007-06-27 at 19:45 +0200, Rodolfo Giometti wrote:
> Ok. Please see the attached patch.

Looks better. All I can find to complain about is the fact that you
return whatever copy_from_user() returns. Don't -- that's the number of
bytes left to copy. It should be if (copy_from_user(..)) return -EFAULT;

--
dwmw2