From: Andi Kleen <ak@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Adrian Bunk <bunk@stusta.de>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Christoph Hellwig <hch@infradead.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: Please revert 21564fd2a3deb48200b595332f9ed4c9f311f2a7
Date: Mon, 9 Jul 2007 12:35:09 +0200 [thread overview]
Message-ID: <200707091235.09772.ak@suse.de> (raw)
In-Reply-To: <20070709110605.4efaea8b@the-village.bc.nu>
On Monday 09 July 2007 12:06:05 Alan Cox wrote:
> On Mon, 9 Jul 2007 11:39:25 +0200
> Andi Kleen <ak@suse.de> wrote:
>
> >
> > > > It will be solved differently longer term, but short term the fix
> > > > was still needed. There are limits on what can be done late
> > > > in the release cycle so simple patches win.
> > >
> > > Your patch got into Linus' tree in the middle of the merge window...
> >
> > Even in the middle of the merge window it might be too late
> > to do some large scale restructuring (as would have been needed
> > for this particular issue)
>
> You should have reverted the change and held it over for 2.6.23-rc1 then
> as other developers do with problem code.
Didn't seem justified.
If someone really wanted to do evil binary only virtualization there
are lots of other ways to do this anyways (e.g. just patching the code
or looking for the paravirt_ops struct signature in memory)
-Andi
next prev parent reply other threads:[~2007-07-09 10:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-17 21:42 Please revert 21564fd2a3deb48200b595332f9ed4c9f311f2a7 Adrian Bunk
2007-06-18 4:43 ` Jeremy Fitzhardinge
2007-07-08 22:44 ` Adrian Bunk
2007-07-08 23:02 ` Andi Kleen
2007-07-08 23:17 ` Adrian Bunk
2007-07-09 9:39 ` Andi Kleen
2007-07-09 10:06 ` Alan Cox
2007-07-09 10:35 ` Andi Kleen [this message]
2007-07-09 9:32 ` Alan Cox
2007-07-09 9:39 ` Andi Kleen
2007-07-09 14:06 ` Jeremy Fitzhardinge
2007-07-09 2:46 ` Jeremy Fitzhardinge
2007-07-09 9:51 ` Alan Cox
2007-07-09 13:55 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707091235.09772.ak@suse.de \
--to=ak@suse.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bunk@stusta.de \
--cc=hch@infradead.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox