From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756010AbXGIKvg (ORCPT ); Mon, 9 Jul 2007 06:51:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751673AbXGIKv3 (ORCPT ); Mon, 9 Jul 2007 06:51:29 -0400 Received: from 85.8.24.16.se.wasadata.net ([85.8.24.16]:46983 "EHLO smtp.drzeus.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752501AbXGIKv2 (ORCPT ); Mon, 9 Jul 2007 06:51:28 -0400 Date: Mon, 9 Jul 2007 12:51:25 +0200 From: Pierre Ossman To: Nicolas Ferre Cc: wux@landicorp.com, Linux Kernel list , Hamish Guthrie , Andrew Victor , ARM Linux Mailing List Subject: Re: [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts Message-ID: <20070709125125.4d4bc2bc@poseidon.drzeus.cx> In-Reply-To: <4688FE50.7050806@drzeus.cx> References: <4688EC94.1090901@rfo.atmel.com> <4688FE50.7050806@drzeus.cx> X-Mailer: Claws Mail 2.10.0 (GTK+ 2.11.5; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Jul 2007 15:32:00 +0200 Pierre Ossman wrote: > Nicolas Ferre wrote: > > Fixes hanging using multi block operations (seen during CMD25). > > Follows closely the datasheet flowcharts. > > > > This piece of code handles better big file writing. I had to take > > care of the notbusy signal during write (at91_mci_handle_cmdrdy > > function) and to rearrange the AT91_MCI_ENDRX and AT91_MCI_RXBUFF > > flag usage. > > > > Signed-off-by: Nicolas Ferre > > --- > > Most of the patch looks ok. Do you want to wait for some more tests > or should I chuck this into the imminent merge window? > *ping* -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org