public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: akpm@linux-foundation.org, ak@suse.de, clameter@sgi.com,
	rientjes@google.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] try parent numa_node at first before using default
Date: Mon, 9 Jul 2007 17:44:16 -0700	[thread overview]
Message-ID: <20070710004416.GA6905@kroah.com> (raw)
In-Reply-To: <200707031731.02456.yinghai.lu@sun.com>

On Tue, Jul 03, 2007 at 05:31:02PM -0700, Yinghai Lu wrote:
> [PATCH 1/4] try parent numa_node at first before using default
> 
> Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>
> 
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index dd40d78..c344d82 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -547,6 +547,8 @@ static void klist_children_put(struct klist_node *n)
>  
>  void device_initialize(struct device *dev)
>  {
> +	int node;
> +
>  	kobj_set_kset_s(dev, devices_subsys);
>  	kobject_init(&dev->kobj);
>  	klist_init(&dev->klist_children, klist_children_get,
> @@ -557,7 +559,9 @@ void device_initialize(struct device *dev)
>  	spin_lock_init(&dev->devres_lock);
>  	INIT_LIST_HEAD(&dev->devres_head);
>  	device_init_wakeup(dev, 0);
> -	set_dev_node(dev, -1);
> +
> +	node = dev->parent ? dev_to_node(dev->parent) : -1;
> +	set_dev_node(dev, node);
>  }

What is this going to give us?

Doesn't it mean that all devices will end up on the same node?

thanks,

greg k-h

  reply	other threads:[~2007-07-10  0:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200707031835.l63IZo9K008197@imap1.linux-foundation.org>
2007-07-04  0:31 ` [PATCH 1/4] try parent numa_node at first before using default Yinghai Lu
2007-07-10  0:44   ` Greg KH [this message]
2007-07-10  0:52     ` Christoph Lameter
2007-07-10  4:49       ` Greg KH
2007-07-10  6:22         ` Yinghai Lu
2007-07-10  1:03     ` Yinghai Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070710004416.GA6905@kroah.com \
    --to=greg@kroah.com \
    --cc=Yinghai.Lu@Sun.COM \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox